Re: [Bluez-devel] [PATCH] SCO flow control

[Fabien Chevalier <fabchevalier@free.fr>]

Hi Marcel,

A just thought to a few more things related to a sco socket.
I just though to a real advantage of using socket for SCO (vs ALSA 
device or character device).
Using a character or block device usually means that the device is 
connected. You can plug your USB mass storage device, and the /dev/sda 
will be usefull.
Sockets are usually used to connect to devices that the OS does not know 
if they exist or not (think to a distant IP host: the kernel has no way 
of knowing if it is valid are not. The connect call will just ask the 
kernel to 'give a try', and bail out if the device does not exist).
Having said that, this is really quite similar to the bluetooth 
technology, where before you have tryed to connect, you don't know if 
the device is on or off...)

And for kfifo use: it make sense, however the bad point is that all 
bluez stack is coded with sk_buffs all over the place. Using kfifo
today will mean having to do the following convertion:

(hci core) kfifo --> (hci device) sk_buff

I think for now i'm gonna stick with sk_buffs :-)
However i will have a look to see how to queue sk_buffs at hci core 
layer instead of socket layer :-)

Cheers,

Fabien


_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel