Re: [Bluez-devel] Big patch to a2dpd

Li, Lea
2006-09-02T06:21:34Z

[-- Attachment #1: Type: text/plain, Size: 2040 bytes --]

It's really a great patch - which is the right patch I am looking for. :)

I've tried it on my XScale board. It is perfect but only one line to be modified to make default alsa device work smoothly. See below patch:
The better way is to modify the code in alsa_transfer_raw(), I think, as below:

case -EPIPE:
// To manage underrun, we will try to recover from error state
if(xrun_recovery(alsa->playback_handle, result) == 0)
result = 0;
DBG("EPIPE(%d)", result);
break;
case -ESTRPIPE:
if(xrun_recovery(alsa->playback_handle, result) == 0)
result=0;
DBG("ESTRPIPE(%d)", result);
break;
}

========patch begin========
--- a2dpd.c.old 2006-09-02 13:53:31.601040096 +0800
+++ a2dpd.c 2006-09-02 13:14:53.065511072 +0800
@@ -716,7 +716,7 @@
blockstart += blocksize;
ibytespersecond += transfer;
a2dp_timer_notifyframe(&TimerInfos);
- } else {
+ } else if (! (lpDevice->bredirectalsa)){
printf("Error in a2dp_transfer_raw\n");
bError = 1;
}
========patch end========

Thanks,
Lea

-----Original Message-----
From: bluez-devel-bounces@lists.sourceforge.net [mailto:bluez-devel-bounces@lists.sourceforge.net] On Behalf Of Frédéric DALLEAU
Sent: 2006年9月1日 0:05
To: BlueZ development
Subject: [Bluez-devel] Big patch to a2dpd

Hi Brad,
>
> I looked over Matthew's patches and applied them. I applied your "small
> patch" which turns out to be bigger than it sounds :)
>
This one is more than bigger!
Reindent,
Alsa output redirection,
New on-the-fly in-play switch from bt to alsa and reverse
Changing bdaddr in play too.
More options described in sample.a2dprc

I removed the line LIBS= from Makefile.am as suggested. This line was
making tons of compilation problems. As a2dpd finally links to alsa, it
is no longer needed.
Please give it a try before submitting (Matthew and RUI if you read that).

Wrote a doc : http://fdalleau.free.fr/a2dp_doc.pdf ideas welcome!

Frédéric

[-- Attachment #2: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]