Re: [Bluez-devel] Big patch to a2dpd

Li, Lea
2006-09-06T03:12:18Z

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

Yes. I prefer modifying alsa_transfer_raw(), which makes the framework logic consistent. How do you think about it?

Thanks,
Lea

-----Original Message-----
From: bluez-devel-bounces@lists.sourceforge.net [mailto:bluez-devel-bounces@lists.sourceforge.net] On Behalf Of Brad Midgley
Sent: 2006年9月6日 11:06
To: BlueZ development
Subject: Re: [Bluez-devel] Big patch to a2dpd

Lea

You seem to be proposing two different changes below. Do we need to
discuss which one is best?

thanks
Brad

> I've tried it on my XScale board. It is perfect but only one line to be modified to make default alsa device work smoothly. See below patch:
> The better way is to modify the code in alsa_transfer_raw(), I think, as below:
>
> case -EPIPE:
> // To manage underrun, we will try to recover from error state
> if(xrun_recovery(alsa->playback_handle, result) == 0)
> result = 0;
> DBG("EPIPE(%d)", result);
> break;
> case -ESTRPIPE:
> if(xrun_recovery(alsa->playback_handle, result) == 0)
> result=0;
> DBG("ESTRPIPE(%d)", result);
> break;
> }
>
> ========patch begin========
> --- a2dpd.c.old 2006-09-02 13:53:31.601040096 +0800
> +++ a2dpd.c 2006-09-02 13:14:53.065511072 +0800
> @@ -716,7 +716,7 @@
> blockstart += blocksize;
> ibytespersecond += transfer;
> a2dp_timer_notifyframe(&TimerInfos);
> - } else {
> + } else if (! (lpDevice->bredirectalsa)){
> printf("Error in a2dp_transfer_raw\n");
> bError = 1;
> }
> ========patch end========
>
> Thanks,
> Lea

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[-- Attachment #2: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]