From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] android/client: Add properly print prefix for hex values
Date: Fri, 06 Jun 2014 06:07:48 +0200 [thread overview]
Message-ID: <4542739.tukqMUaLjY@leonov> (raw)
In-Reply-To: <1401966521-32270-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Thursday 05 of June 2014 13:08:39 Grzegorz Kolodziejczyk wrote:
> This patch fix print hex values by adding "0x" prefix.
> ---
> android/client/if-gatt.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/android/client/if-gatt.c b/android/client/if-gatt.c
> index 0375126..f6e6327 100644
> --- a/android/client/if-gatt.c
> +++ b/android/client/if-gatt.c
> @@ -454,7 +454,7 @@ static void gattc_get_characteristic_cb(int conn_id, int
> status, char srvc_id_buf[MAX_SRVC_ID_STR_LEN];
> char char_id_buf[MAX_CHAR_ID_STR_LEN];
>
> - haltest_info("%s: conn_id=%d status=%d srvc_id=%s char_id=%s,
> char_prop=%x\n", + haltest_info("%s: conn_id=%d status=%d srvc_id=%s
> char_id=%s, char_prop=0x%x\n", __func__, conn_id, status,
> btgatt_srvc_id_t2str(srvc_id, srvc_id_buf),
> btgatt_gatt_id_t2str(char_id, char_id_buf), char_prop);
> @@ -644,7 +644,7 @@ static void gatts_service_added_cb(int status, int
> server_if,
>
> snprintf(server_if_str, sizeof(server_if_str), "%d", server_if);
>
> - haltest_info("%s: status=%d server_if=%d srvc_id=%s handle=%x\n",
> + haltest_info("%s: status=%d server_if=%d srvc_id=%s handle=0x%x\n",
> __func__, status, server_if,
> btgatt_srvc_id_t2str(srvc_id, buf), srvc_handle);
> }
> @@ -654,7 +654,7 @@ static void gatts_included_service_added_cb(int status,
> int server_if, int srvc_handle,
> int incl_srvc_handle)
> {
> - haltest_info("%s: status=%d server_if=%d srvc_handle=%x
> inc_srvc_handle=%x\n", + haltest_info("%s: status=%d server_if=%d
> srvc_handle=0x%x inc_srvc_handle=0x%x\n", __func__, status, server_if,
> srvc_handle, incl_srvc_handle);
> }
> @@ -667,7 +667,7 @@ static void gatts_characteristic_added_cb(int status,
> int server_if, {
> char buf[MAX_SRVC_ID_STR_LEN];
>
> - haltest_info("%s: status=%d server_if=%d uuid=%s srvc_handle=%x
> char_handle=%x\n", + haltest_info("%s: status=%d server_if=%d uuid=%s
> srvc_handle=0x%x char_handle=0x%x\n", __func__, status, server_if,
> gatt_uuid_t2str(uuid, buf),
> srvc_handle, char_handle);
> }
> @@ -679,7 +679,7 @@ static void gatts_descriptor_added_cb(int status, int
> server_if, {
> char buf[MAX_SRVC_ID_STR_LEN];
>
> - haltest_info("%s: status=%d server_if=%d uuid=%s srvc_handle=%x
> descr_handle=%x\n", + haltest_info("%s: status=%d server_if=%d uuid=%s
> srvc_handle=0x%x descr_handle=0x%x\n", __func__, status, server_if,
> gatt_uuid_t2str(uuid, buf),
> srvc_handle, descr_handle);
> }
> @@ -687,21 +687,21 @@ static void gatts_descriptor_added_cb(int status, int
> server_if, /* Callback invoked in response to start_service */
> static void gatts_service_started_cb(int status, int server_if, int
> srvc_handle) {
> - haltest_info("%s: status=%d server_if=%d srvc_handle=%x\n",
> + haltest_info("%s: status=%d server_if=%d srvc_handle=0x%x\n",
> __func__, status, server_if, srvc_handle);
> }
>
> /* Callback invoked in response to stop_service */
> static void gatts_service_stopped_cb(int status, int server_if, int
> srvc_handle) {
> - haltest_info("%s: status=%d server_if=%d srvc_handle=%x\n",
> + haltest_info("%s: status=%d server_if=%d srvc_handle=0x%x\n",
> __func__, status, server_if, srvc_handle);
> }
>
> /* Callback triggered when a service has been deleted */
> static void gatts_service_deleted_cb(int status, int server_if, int
> srvc_handle) {
> - haltest_info("%s: status=%d server_if=%d srvc_handle=%x\n",
> + haltest_info("%s: status=%d server_if=%d srvc_handle=0x%x\n",
> __func__, status, server_if, srvc_handle);
> }
>
> @@ -715,7 +715,7 @@ static void gatts_request_read_cb(int conn_id, int
> trans_id, bt_bdaddr_t *bda, {
> char buf[MAX_ADDR_STR_LEN];
>
> - haltest_info("%s: conn_id=%d trans_id=%d bda=%s attr_handle=%x offset=%d
> is_long=%d\n", + haltest_info("%s: conn_id=%d trans_id=%d bda=%s
> attr_handle=0x%x offset=%d is_long=%d\n", __func__, conn_id, trans_id,
> bt_bdaddr_t2str(bda, buf),
> attr_handle, offset, is_long);
> }
> @@ -732,7 +732,7 @@ static void gatts_request_write_cb(int conn_id, int
> trans_id, bt_bdaddr_t *bda, char buf[MAX_ADDR_STR_LEN];
> char valbuf[100];
>
> - haltest_info("%s: conn_id=%d trans_id=%d bda=%s attr_handle=%x offset=%d
> length=%d need_rsp=%d is_prep=%d value=%s\n", + haltest_info("%s:
> conn_id=%d trans_id=%d bda=%s attr_handle=0x%x offset=%d length=%d
> need_rsp=%d is_prep=%d value=%s\n", __func__, conn_id, trans_id,
> bt_bdaddr_t2str(bda, buf),
> attr_handle, offset, length, need_rsp, is_prep,
> array2str(value, length, valbuf, sizeof(valbuf)));
> @@ -755,7 +755,7 @@ static void gatts_request_exec_write_cb(int conn_id, int
> trans_id, */
> static void gatts_response_confirmation_cb(int status, int handle)
> {
> - haltest_info("%s: status=%d handle=%x\n", __func__, status, handle);
> + haltest_info("%s: status=%d handle=0x%x\n", __func__, status, handle);
> }
>
> static const btgatt_server_callbacks_t btgatt_server_callbacks = {
All patches applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-06-06 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 11:08 [PATCH 1/3] android/client: Add properly print prefix for hex values Grzegorz Kolodziejczyk
2014-06-05 11:08 ` [PATCH 2/3] android/client: Add additional support for handling " Grzegorz Kolodziejczyk
2014-06-05 11:08 ` [PATCH 3/3] android/client: Fix handling hex test arguments Grzegorz Kolodziejczyk
2014-06-06 4:07 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4542739.tukqMUaLjY@leonov \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox