From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] uhid: Remove local copy of uhid header
Date: Tue, 23 Nov 2021 00:06:34 +0100 [thread overview]
Message-ID: <45caaa82b56528fed03e534103f55f2ebbdc3885.camel@hadess.net> (raw)
In-Reply-To: <20211122211707.2219208-1-luiz.dentz@gmail.com>
On Mon, 2021-11-22 at 13:17 -0800, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> uhid.h is part of kernel uapi nowadays so it can be included
> directly from linux/uhid.h so this removes the local copy to use it
> instead.
This will cause the same problems that importing those headers into the
repository was supposed to solve. If you remove those headers, then
older distributions will be stuck on old kernel headers, and bluez
compilations will regularly fail when it uses new structs, struct
members, functions, or constants that are in the upstream uapi headers
but not yet propagated to the user's distribution.
Strong NAK on this one and the uinput header change too.
next prev parent reply other threads:[~2021-11-22 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 21:17 [PATCH v2] uhid: Remove local copy of uhid header Luiz Augusto von Dentz
2021-11-22 21:33 ` [v2] " bluez.test.bot
2021-11-22 23:06 ` Bastien Nocera [this message]
2021-11-22 23:46 ` [PATCH v2] " Luiz Augusto von Dentz
2021-11-23 8:48 ` Bastien Nocera
2021-11-23 13:24 ` Marcel Holtmann
2021-11-23 21:30 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45caaa82b56528fed03e534103f55f2ebbdc3885.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox