Marcel > please also fix the other coding style issues. Some comments and a lot > of if clauses are violating the whitespace requirements. It is "if (" > and not "if(". It is also "(char *) &val" and not "(char *)&val". > > And the code in sco_sock_queue_rcv_skb() is bad. We don't initialize > variables if not really needed. In this case if skb_queue_len() check > fails simply call return -ENOMEM. Strip the label and call return 0 at > the end of the function. Don't make the code more complex than it > actually is. > > And no forward declaration of sco_sock_queue_rcv_skb() if not really > needed. > > Why are we using SCO_TXBUFS and not reuse SO_SNDBUF since the value is > directly mapped to sk_sndbuf. Same applies to sk_rcvbuf. > > And why do we have to do "c->tx_timer.function = hci_sco_tx_timer" over > and over again. Isn't it enough if we set the timer function once after > init of the timer. I believe I've applied all these suggestions. Let me know if there are still any issues. Brad