Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/gatt: Fix possible memory leak
Date: Mon, 26 May 2014 10:47:45 +0200	[thread overview]
Message-ID: <4752905.d9AFggy7r0@uw000953> (raw)
In-Reply-To: <1401089563-9932-1-git-send-email-jakub.tyszkowski@tieto.com>

Hi Jakub,

On Monday 26 of May 2014 09:32:42 Jakub Tyszkowski wrote:
> ---
>  android/gatt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index c8af09c..e7f7c86 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -4440,6 +4440,7 @@ static uint8_t read_by_group_type(const uint8_t *cmd, uint16_t cmd_len,
>  		if (!queue_push_tail(device->pending_requests, entry)) {
>  			queue_remove_all(device->pending_requests, NULL, NULL,
>  						destroy_pending_request);
> +			free(entry);
>  			queue_destroy(q, NULL);
>  			return ATT_ECODE_UNLIKELY;
>  		}
> 

Both patches applied, thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-05-26  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26  7:32 [PATCH 1/2] android/gatt: Fix possible memory leak Jakub Tyszkowski
2014-05-26  7:32 ` [PATCH 2/2] android: Fix sending uninitialised data Jakub Tyszkowski
2014-05-26  8:47 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4752905.d9AFggy7r0@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox