From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
From: Szymon Janc <szymon.janc@tieto.com>
To: Prabhu Chawandi <foss.chaws@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Crash in android/hal-sco.c
Date: Tue, 31 Mar 2015 17:06:14 +0200
Message-ID: <4841807.9Mv5T1jXya@leonov>
In-Reply-To: <CAKafyqooRHOCtKbzWdLeDW4Dr3S151+tz-S0S+YBsRhWADVYsQ@mail.gmail.com>
References: <CAKafyqooRHOCtKbzWdLeDW4Dr3S151+tz-S0S+YBsRhWADVYsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On Tuesday 31 of March 2015 18:43:16 Prabhu Chawandi wrote:
> Hi,
> 
>   I was trying to do SCO read using haltest but I was getting FPERROR.
> 
> So further I went debug coredump
> 
> 
> static ssize_t in_read(struct audio_stream_in *stream, void *buffer,
>                                                                 size_t
> bytes) {
>         struct sco_stream_in *in = (struct sco_stream_in *) stream;
> #if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
>         size_t frame_size = audio_stream_in_frame_size(&in->stream);
> #else
>         size_t frame_size = audio_stream_frame_size(&stream->common);
> #endif
> 
>         size_t frame_num = bytes / frame_size; ===> Floating point error.
> 
>         size_t input_frame_num = frame_num;
> 
> 
> I am getting channel number as 1  from audio_channel_count_from_in_mask
> 
> which is reserved for future hence I am getting zero as return which
> leading to the crash

Thanks for reporting.
I've just send a patch "android/hal-sco: Fix divide by zero". This should fix 
the crash so please test.

-- 
BR
Szymon Janc