Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] android/tester: Make client2 app uuid value name consistent
Date: Thu, 02 Oct 2014 13:51:13 +0200	[thread overview]
Message-ID: <4907090.RgJ2BYQ5Al@uw000953> (raw)
In-Reply-To: <1412076227-32664-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>

Hi Grzegorz,

On Tuesday 30 of September 2014 13:23:42 Grzegorz Kolodziejczyk wrote:
> Application uudis for tester should be name unified and consistent.
> ---
>  android/tester-gatt.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/android/tester-gatt.c b/android/tester-gatt.c
> index 693a8a3..b1c6ece 100644
> --- a/android/tester-gatt.c
> +++ b/android/tester-gatt.c
> @@ -56,6 +56,11 @@ static bt_uuid_t app1_uuid = {
>  				0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01 },
>  };
>  
> +static bt_uuid_t app2_uuid = {
> +	.uu = { 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02,
> +				0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02 },
> +};
> +
>  struct emu_cid_data {
>  	const int pdu_len;
>  	const void *pdu;
> @@ -117,11 +122,6 @@ struct write_char_data {
>  	char *p_value;
>  };
>  
> -static bt_uuid_t client2_app_uuid = {
> -	.uu = { 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02,
> -				0x02, 0x02, 0x02, 0x02, 0x02, 0x02, 0x02 },
> -};
> -
>  static bt_bdaddr_t emu_remote_bdaddr_val = {
>  	.address = { 0x00, 0xaa, 0x01, 0x01, 0x00, 0x00 },
>  };
> @@ -1117,7 +1117,7 @@ static struct test_case test_cases[] = {
>  		ACTION_SUCCESS(emu_set_connect_cb_action, gatt_conn_cb),
>  		ACTION_SUCCESS(gatt_client_register_action, &app1_uuid),
>  		CALLBACK_STATUS(CB_GATTC_REGISTER_CLIENT, BT_STATUS_SUCCESS),
> -		ACTION_SUCCESS(gatt_client_register_action, &client2_app_uuid),
> +		ACTION_SUCCESS(gatt_client_register_action, &app2_uuid),
>  		CALLBACK_STATUS(CB_GATTC_REGISTER_CLIENT, BT_STATUS_SUCCESS),
>  		ACTION_SUCCESS(gatt_client_start_scan_action,
>  							INT_TO_PTR(APP1_ID)),
> 

Please rebase and resend. Thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-10-02 11:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 11:23 [PATCH 1/6] android/tester: Make client2 app uuid value name consistent Grzegorz Kolodziejczyk
2014-09-30 11:23 ` [PATCH 2/6] android/tester: Fix debug callback logs Grzegorz Kolodziejczyk
2014-09-30 11:23 ` [PATCH 3/6] android/tester: Change GATT client connection test cases to LE connect Grzegorz Kolodziejczyk
2014-09-30 11:23 ` [PATCH 4/6] android/tester: Add GATT server connect successful test case Grzegorz Kolodziejczyk
2014-09-30 11:23 ` [PATCH 5/6] android/tester: Add GATT server disconnect " Grzegorz Kolodziejczyk
2014-09-30 11:23 ` [PATCH 6/6] android/tester: Add GATT server multiple connect succesful " Grzegorz Kolodziejczyk
2014-10-02 11:51 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4907090.RgJ2BYQ5Al@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=grzegorz.kolodziejczyk@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox