Re: [PATCH BlueZ v2 0/5] Use composition data to validate app against the node

["Stotland, Inga" <inga.stotland@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

Hi Michal,

On Tue, 2019-07-23 at 12:06 +0200, Michał Lowas-Rzechonek wrote:
> This patchset streamlines app validation by creating a temporary node
> during Attach, Join and CreateNetwork calls, then validating its
> composition data to:
>  - fit in Config Model Composition Data Get message
>  - declare mandatory models on primary element
>  - declare consecutive element indexes
> 
> During Attach call, temporary composition data is also compared with
> data generated for existing node, guaranteeing immutablity required
> by
> the specification.
> 
> Michał Lowas-Rzechonek (5):
>   mesh: Convert void pointers to anonymous unions in
> managed_obj_request
>   mesh: Validate application by comparing composition data
>   mesh: Keep element and model lists sorted and unique
>   mesh: Check that element indexes are consecutive
>   mesh: Check that config server is present in primary element
> 
>  mesh/mesh-defs.h |   2 +
>  mesh/node.c      | 507 ++++++++++++++++++++++-----------------------
> --
>  2 files changed, 241 insertions(+), 268 deletions(-)
> 

I agree with the general idea of this change. There are just a couple
of things that need to be fixed (sent as comments to a specific patch).

Regards,
Inga

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3265 bytes --]