Re: [PATCH BlueZ 01/15] mesh: crypto: remove dead function declaration

[Christian Eggers <ceggers@arri.de>]

Hi Luiz,

On Tuesday, 8 July 2025, 16:59:20 CEST, Luiz Augusto von Dentz wrote:
> Hi Christian,
> 
> On Tue, Jul 8, 2025 at 9:15 AM Christian Eggers <ceggers@arri.de> wrote:
> >
> > The implementation of mesh_aes_ecb_one() has been removed in commit
> > dfed4839463f ("mesh: Convert crypto to use ELL wrappers").
> > ---
> >  mesh/crypto.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/mesh/crypto.h b/mesh/crypto.h
> > index 55789886eb0e..3d85785f174c 100644
> > --- a/mesh/crypto.h
> > +++ b/mesh/crypto.h
> > @@ -22,8 +22,6 @@ bool mesh_crypto_aes_ccm_decrypt(const uint8_t nonce[13], const uint8_t key[16],
> >                                 const void *enc_msg, uint16_t enc_msg_len,
> >                                 void *out_msg,
> >                                 void *out_mic, size_t mic_size);
> > -bool mesh_aes_ecb_one(const uint8_t key[16],
> > -                       const uint8_t plaintext[16], uint8_t encrypted[16]);
> >  bool mesh_crypto_nkik(const uint8_t network_key[16], uint8_t identity_key[16]);
> >  bool mesh_crypto_nkbk(const uint8_t network_key[16], uint8_t beacon_key[16]);
> >  bool mesh_crypto_nkpk(const uint8_t network_key[16], uint8_t private_key[16]);
> > --
> > 2.43.0
> 
> Is this set just a cleanup, no logical changes were made? In that case
> I can probably go ahead and push it myself, otherwise I may ask Brian
> to step in to review.
sorry for not adding a cover letter.

Most of the patches only cleanup obsolete function prototypes or unused structs.
Patch #5 fixes a NULL pointer dereference (I think it's trivial), whilst 
patch #10 replaces some magic number by preprocessor definitions. 
Patches #14 + #15 try to improve readability.

I considered CC'ing Brian, but I decided using this limited time for more 
important stuff (I hope he can do the initial review of my MESH-GATT RFC
this week).

regards,
Christian
> 
> >
> 
> 
>