From: Roel Kluin <roel.kluin@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Bluetooth: i reaches pkts_to_be_removed + 1
Date: Wed, 25 Feb 2009 23:53:55 +0100 [thread overview]
Message-ID: <49A5CC03.7020906@gmail.com> (raw)
In-Reply-To: <1235601640.27004.5.camel@localhost.localdomain>
>> i reaches pkts_to_be_removed + 1
> patch looks good, but can you please fill in the commit message with a
> little bit more details and background.
This was found by code inspection by the way, and not tested.
how about:
------------------------------>8-------------8<---------------------------------
When all packets are removed 'i' reaches pkts_to_be_removed + 1, so the
error message was printed upon success, and not when the last packet
wasn't removed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index 894b2cb..177f34b 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -385,7 +385,7 @@ static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
spin_unlock_irqrestore(&bcsp->unack.lock, flags);
- if (i != pkts_to_be_removed)
+ if (i <= pkts_to_be_removed)
BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
}
next prev parent reply other threads:[~2009-02-25 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 21:58 [PATCH] Bluetooth: i reaches pkts_to_be_removed + 1 Roel Kluin
2009-02-25 22:40 ` Marcel Holtmann
2009-02-25 22:53 ` Roel Kluin [this message]
2009-02-25 23:08 ` David Sainty
2009-02-25 23:43 ` Marcel Holtmann
2009-03-02 12:37 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5CC03.7020906@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox