From: "Marc Pignat" <Marc.Pignat@hevs.ch>
To: <marcel@holtmann.org>,<jkosina@suse.cz>
Cc: <ext-roger.quadros@nokia.com>,<linux-bluetooth@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [BUG] 2.6.30-rc4 hid bluetooth not working
Date: Sat, 02 May 2009 10:45:41 +0200 [thread overview]
Message-ID: <49FC2455020000BF000290DA@mailgw2.hevs.ch> (raw)
>>> Marcel Holtmann <marcel@holtmann.org> 05/02/09 12:57 AM >>>
>Hi Jiri,
>
>> > Subject: bluetooth: Fix serialization when adding/deleting connections=
in hci_sysfs
>> >=20
>> > add_conn and del_conn should be serialized, but flush_workqueue can't =
be used
>> > by the worker thread on it's own queue, so use flush_work to =
serialize add_conn
>> > and del_conn against each other.
>> >=20
>> > Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
>>=20
>> Acked-by: Jiri Kosina <jkosina@suse.cz>
>>=20
>> FWIW.
>
>nak from my side since I think it is the wrong fix. We really wanna wait
>for all works to finish here. This includes work from other connection
>attempts or terminations.
IMHO, there is no need to wait for work currently running, since this is a
singlethread workqueue.
But it is perhaps simpler to use a lock (mutex or watherver locking =
primitive).
Regards
Marc
next reply other threads:[~2009-05-02 8:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 8:45 Marc Pignat [this message]
2009-05-02 14:08 ` [BUG] 2.6.30-rc4 hid bluetooth not working Dave Young
2009-05-02 19:42 ` Marcel Holtmann
2009-05-02 20:19 ` Justin Mattock
2009-05-02 20:21 ` Marcel Holtmann
2009-05-02 21:07 ` Justin P. Mattock
2009-05-02 21:14 ` Marcel Holtmann
2009-05-02 21:31 ` Justin P. Mattock
2009-05-02 17:03 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2009-05-03 14:55 Marc Pignat
2009-05-03 20:17 ` Marcel Holtmann
2009-05-03 21:18 ` Marc Pignat
2009-05-04 7:57 ` Roger Quadros
2009-05-01 0:37 Marc Pignat
2009-05-01 22:20 ` Jiri Kosina
2009-05-01 22:56 ` Marcel Holtmann
2009-04-30 15:32 Marc Pignat
2009-04-30 14:49 Marc Pignat
2009-04-30 13:20 Marc Pignat
2009-04-30 13:57 ` Jiri Kosina
2009-04-30 15:03 ` Marcel Holtmann
2009-04-30 18:58 ` Jiri Kosina
2009-04-30 22:34 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FC2455020000BF000290DA@mailgw2.hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=ext-roger.quadros@nokia.com \
--cc=jkosina@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox