From: Martin Sucha <martin.sucha@jts-sro.sk>
To: Forrest Zhao <forrest.zhao@intel.com>
Cc: linux-bluetooth@vger.kernel.org, forrest.zhao@gmail.com
Subject: Re: [PATCH] fix bugs in HFP HF role audio part
Date: Tue, 30 Jun 2009 09:46:21 +0200 [thread overview]
Message-ID: <4A49C2CD.2060207@jts-sro.sk> (raw)
In-Reply-To: <1246346181-25864-1-git-send-email-forrest.zhao@intel.com>
Hi Forrest,
> @@ -1137,7 +1142,11 @@ gboolean gateway_request_stream(struct audio_device *dev,
> GError *err = NULL;
> GIOChannel *io;
>
> - if (!gw->sco) {
> + if (!gw->rfcomm) {
> + gw->sco_start_cb = cb;
> + gw->sco_start_cb_data = user_data;
> + get_records(dev);
> + } else if (!gw->sco) {
> if (!gw->rfcomm)
> return FALSE;
It seems that this return FALSE statement would never be reached. Is
it left there intentionally?
Regards
Martin Sucha
prev parent reply other threads:[~2009-06-30 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 7:16 [PATCH] fix bugs in HFP HF role audio part Forrest Zhao
2009-06-30 7:36 ` Johan Hedberg
2009-06-30 7:46 ` Martin Sucha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A49C2CD.2060207@jts-sro.sk \
--to=martin.sucha@jts-sro.sk \
--cc=forrest.zhao@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox