Re: [PATCH v3] hciattach application support for Atheros AR300x Bluetooth Chip

[Suraj Sumangala <suraj@atheros.com>]

Hi Marcel,

Marcel Holtmann wrote:
> Hi Suraj,
> 
>> Implements support for Atheros AR300x Bluetooth chip in hciattach. 
>> Adds feature to bring up AR300x Bluetooth chip
>> with and without enhanced power management enabled.
>>
>> Signed-off-by: Suraj <suraj@Atheros.com>
> 
> not SOBs for BlueZ userspace. That is kernel only.
> 
>> ---
>>  Makefile.tools         |    1 +
>>  tools/hciattach.8      |    6 +
>>  tools/hciattach.c      |  111 +++++
>>  tools/hciattach.h      |    3 +
>>  tools/hciattach_ar3k.c | 1223 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 1344 insertions(+), 0 deletions(-)
>>  create mode 100755 tools/hciattach_ar3k.c
> 
> While hciattach is kinda the bad sheep inside BlueZ, I will enforce the
> general coding style for it for all new contributions. So could you
> please fix that one first. Otherwise it makes no sense for me to go
> through such a big patch if I have to complain about the coding style
> breakage for every second line. A general rule is if it fails
> check-patch.pl from the kernel, then you are doing something wrong.
> 
> Regards
> 
> Marcel
> 
> 

I had verified this patch using checkpatch and it did not complain. I 
had also verified it manually according to the comments others have 
given previously for different patches.

If you still see issues, then we can add that check too to checkpatch if 
possible.

Being a big patch, there are bound to be problems.But I would appreciate 
if you could review atleast part of it and  give your comments. I can do 
the changes for the full patch.

Also I would request others in the community to pitch in.

Regards
Suraj