linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabian Greffrath <fabian@greffrath.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: WRT non-UTF-8 device names
Date: Tue, 25 May 2010 14:56:57 +0200	[thread overview]
Message-ID: <4BFBC919.8030604@greffrath.com> (raw)
In-Reply-To: <1274791119.27274.17718.camel@localhost.localdomain>

Am 25.05.2010 14:38, schrieb Bastien Nocera:
> The output of "locale" as root would probably help.

Here you are:
$ su -c locale
LANG=de_DE.UTF-8
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

> My guess is that we make assumptions as to a user entry being valid
> UTF-8 somewhere, when it could be non-UTF-8.
>
> As for your problem, I don't think we want to allow non-UTF-8 device
> names anyhow. They're not valid spec.

Sure, that's why my patch converts the device name to valid UTF-8 as 
soon as it is possible to detect that it is actually non-UTF-8. 
However, it may be right that this approach only fixes the symptoms 
and does not cure the illness. But my knowledge of the Bluez code is 
not deep enough to track down the real issue on my own.

Thanks for your reply anyway,
Fabian

      reply	other threads:[~2010-05-25 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21  9:01 WRT non-UTF-8 device names Fabian Greffrath
2010-05-25 11:35 ` Fabian Greffrath
2010-05-25 12:38 ` Bastien Nocera
2010-05-25 12:56   ` Fabian Greffrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFBC919.8030604@greffrath.com \
    --to=fabian@greffrath.com \
    --cc=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).