From: David Vrabel <david.vrabel@csr.com>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
rshaffer@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/1] Bluetooth: Add socket option definitions for AMP
Date: Wed, 18 Aug 2010 14:45:52 +0100 [thread overview]
Message-ID: <4C6BE410.1020505@csr.com> (raw)
In-Reply-To: <1282086426-8423-1-git-send-email-mathewm@codeaurora.org>
Mat Martineau wrote:
> This adds a new BT_AMP socket option to control the use of AMP channels.
> It is for use with the SOL_BLUETOOTH option level on L2CAP sockets.
>
> Available option values are defined as:
>
> [lots of nice documentation]
Why is none of this documentation in the code?
I believe we also agreed that this policy could be changed at any point
in the life time of the channel so this should be documented as well.
> +#define BT_AMP 8
Suggest BT_AMP_POLICY, BT_AMP_POLICY_REQUIRE_BR_EDR etc. Just in case
there are other AMP related socket options in the future.
> +#define BT_AMP_REQUIRE_BR_EDR 0
> +#define BT_AMP_PREFER_AMP 1
> +#define BT_AMP_PREFER_BR_EDR 2
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2010-08-18 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 23:07 [PATCH 1/1] Bluetooth: Add socket option definitions for AMP Mat Martineau
2010-08-18 13:45 ` David Vrabel [this message]
2010-08-27 18:06 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6BE410.1020505@csr.com \
--to=david.vrabel@csr.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathewm@codeaurora.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).