Re: [PATCH] linux-firmware: Remove ath3k-2.fw

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[Bala Shanmugam]

On 1/28/2011 3:03 PM, Shanmugamkamatchi Balashanmugam wrote:
> ath3k-2.fw is obsolete and not use by Atheros chipsets
> anymore.
>
> Signed-off-by: Bala Shanmugam<sbalashanmugam@atheros.com>
> ---
>   WHENCE     |    9 ---------
>   ath3k-2.fw |  Bin 246804 ->  0 bytes
>   2 files changed, 0 insertions(+), 9 deletions(-)
>   delete mode 100644 ath3k-2.fw
>
> diff --git a/WHENCE b/WHENCE
> index 1cbd0a6..c022b4a 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1306,15 +1306,6 @@ Licence: Redistributable, provided by Realtek in their driver
>
>   --------------------------------------------------------------------------
>
> -Driver: DFU Driver for Atheros bluetooth chipset AR3011
> -
> -File: ath3k-2.fw
> -Info: v2.0
> -
> -Licence: Redistributable. See LICENCE.atheros_firmware for details
> -
> ---------------------------------------------------------------------------
> -
>   Driver: lgs8gxx - Legend Silicon GB20600 demodulator driver
>
>   File: lgs8g75.fw
> diff --git a/ath3k-2.fw b/ath3k-2.fw
> deleted file mode 100644
> index 3fa8cff36301a7005936d54a407d6879923aa354..0000000000000000000000000000000000000000
> GIT binary patch
> literal 0
> HcmV?d00001
>
> literal 246804
>
Hi David,

Can you please upload this patch sent before.

Regards,
Bala.

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[David Woodhouse]

On Fri, 2011-01-28 at 15:03 +0530, Bala Shanmugam wrote:
> ath3k-2.fw is obsolete and not use by Atheros chipsets
> anymore. 

Are you telling me that there is no extant hardware, and no old kernels,
which would use this? It was added to the linux-firmware tree and
*never* used?

-- 
dwmw2

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[Bala Shanmugam]

On 2/3/2011 1:13 PM, David Woodhouse wrote:
> On Fri, 2011-01-28 at 15:03 +0530, Bala Shanmugam wrote:
>> ath3k-2.fw is obsolete and not use by Atheros chipsets
>> anymore.
> Are you telling me that there is no extant hardware, and no old kernels,
> which would use this? It was added to the linux-firmware tree and
> *never* used?
>
Yes David, no older kernel uses this firmware.
We thought to have new firmware file for newer versions but
our driver patch was not accepted and we decided to
have single firmware for this chipset [ath3k-1.fw].

Thanks and Regards,
Bala.

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[Luis R. Rodriguez]

On Thu, Feb 03, 2011 at 12:01:37AM -0800, Shanmugamkamatchi Balashanmugam wrote:
> On 2/3/2011 1:13 PM, David Woodhouse wrote:
> > On Fri, 2011-01-28 at 15:03 +0530, Bala Shanmugam wrote:
> >> ath3k-2.fw is obsolete and not use by Atheros chipsets
> >> anymore.
> > Are you telling me that there is no extant hardware, and no old kernels,
> > which would use this? It was added to the linux-firmware tree and
> > *never* used?
> >
> Yes David, no older kernel uses this firmware.
> We thought to have new firmware file for newer versions but
> our driver patch was not accepted and we decided to
> have single firmware for this chipset [ath3k-1.fw].
> 

To be clear, the patch for upstream to use that firmware was submitted IIRC but
never merged upstream... you merged the firmware first. By the time it came
time to push it again, I had asked WTF was in it, and asked for the patch to
get merged, but it was made clear by our team the APIs never changed so Marcel
suggested we just replace the firmware in linux-firmware instead of adding a
new firmware and patching the driver.

Apologies for any trouble.

  Luis

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[Bala Shanmugam]

On 2/3/2011 11:16 PM, Luis Rodriguez wrote:
> On Thu, Feb 03, 2011 at 12:01:37AM -0800, Shanmugamkamatchi Balashanmugam wrote:
>> On 2/3/2011 1:13 PM, David Woodhouse wrote:
>>> On Fri, 2011-01-28 at 15:03 +0530, Bala Shanmugam wrote:
>>>> ath3k-2.fw is obsolete and not use by Atheros chipsets
>>>> anymore.
>>> Are you telling me that there is no extant hardware, and no old kernels,
>>> which would use this? It was added to the linux-firmware tree and
>>> *never* used?
>>>
>> Yes David, no older kernel uses this firmware.
>> We thought to have new firmware file for newer versions but
>> our driver patch was not accepted and we decided to
>> have single firmware for this chipset [ath3k-1.fw].
>>
> To be clear, the patch for upstream to use that firmware was submitted IIRC but
> never merged upstream... you merged the firmware first. By the time it came
> time to push it again, I had asked WTF was in it, and asked for the patch to
> get merged, but it was made clear by our team the APIs never changed so Marcel
> suggested we just replace the firmware in linux-firmware instead of adding a
> new firmware and patching the driver.
>
> Apologies for any trouble.
>
>    Luis
Hi David,

Please upstream this patch.
Let me know if I need to do anything from my side.

Regards,
Bala.

Re: [PATCH] linux-firmware: Remove ath3k-2.fw

[Bala Shanmugam]

On 2/3/2011 1:31 PM, Bala Shanmugam wrote:
> On 2/3/2011 1:13 PM, David Woodhouse wrote:
>> On Fri, 2011-01-28 at 15:03 +0530, Bala Shanmugam wrote:
>>> ath3k-2.fw is obsolete and not use by Atheros chipsets
>>> anymore.
>> Are you telling me that there is no extant hardware, and no old kernels,
>> which would use this? It was added to the linux-firmware tree and
>> *never* used?
>>
> Yes David, no older kernel uses this firmware.
> We thought to have new firmware file for newer versions but
> our driver patch was not accepted and we decided to
> have single firmware for this chipset [ath3k-1.fw].
>
> Thanks and Regards,
> Bala.
>
>
Hi David,

Can you please remove this firmware.
If you have any concerns please let me know.

Regards,
Bala.