From: Brian Gix <bgix@codeaurora.org>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
par-gunnar.p.hjalmdahl@stericsson.com,
henrik.possung@stericsson.com
Subject: Re: [PATCH] Bluetooth: Add counter for not acked HCI commands
Date: Tue, 01 Mar 2011 11:29:42 -0800 [thread overview]
Message-ID: <4D6D4926.907@codeaurora.org> (raw)
In-Reply-To: <1299003369-17901-1-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Again,
On 11-03-01 10:16 AM, Andrzej Kaczmarek wrote:
[...]
> atomic_dec(&hdev->cmd_cnt);
> + atomic_inc(&hdev->cmd_not_ack);
[...]
Also, I am not sure this means what you may intend it to mean. I think
that this is intended to do both of these operations "together
atomically", but that as written, it is possible for an interruption to
occur between the two operations.
--
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
prev parent reply other threads:[~2011-03-01 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 18:16 [PATCH] Bluetooth: Add counter for not acked HCI commands Andrzej Kaczmarek
2011-03-01 19:25 ` Brian Gix
2011-03-04 12:37 ` Andrzej Kaczmarek
2011-03-04 16:12 ` Brian Gix
2011-03-16 21:30 ` Gustavo F. Padovan
2011-03-16 22:50 ` Brian Gix
2011-03-16 23:27 ` Gustavo F. Padovan
2011-03-18 9:22 ` Andrzej Kaczmarek
2011-03-01 19:29 ` Brian Gix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6D4926.907@codeaurora.org \
--to=bgix@codeaurora.org \
--cc=andrzej.kaczmarek@tieto.com \
--cc=henrik.possung@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).