linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Michalski" <rafal.michalski@comarch.pl>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 1/2] Refactoring address fields handled in vcard module
Date: Fri, 26 Aug 2011 09:24:37 +0200	[thread overview]
Message-ID: <4E574A35.30106@comarch.pl> (raw)
In-Reply-To: <1314009177-19178-1-git-send-email-michalski.raf@gmail.com>

Hi Johan
> This patch introduces phonebook_addr struct for more intuitive
> handling address fields from backend. Now address fields are managed
> by linked list (wrapped by structure) and it is used for printing vCard
> address fields, instead of buffers set (combined with g_strsplit
> and snprintf functions).
> ---
>  plugins/phonebook-tracker.c |   72 +++++++++++++++++++++++++++++++++++++-----
>  plugins/vcard.c             |   70 +++++++++++++++++++----------------------
>  plugins/vcard.h             |    7 +++-
>  3 files changed, 101 insertions(+), 48 deletions(-)
>   

I want to ask about patches review:

[PATCH obexd 1/2] Refactoring address fields handled in vcard module
[PATCH obexd 2/2] Fix semicolon delimiter issue in address fields

Did you have time to take a look at these patches ?

And please ignore patch I've sent earlier: "[PATCH obexd v2] Support for 
Quoted Printable encoding".
I will send new improved version later, with additional escaping 
semicolons only (since it is required
by vCard 2.1), if these two above patches accepted.

Best Regards

Rafał Michalski

  parent reply	other threads:[~2011-08-26  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 10:32 [PATCH obexd 1/2] Refactoring address fields handled in vcard module Rafal Michalski
2011-08-22 10:32 ` [PATCH obexd 2/2] Fix semicolon delimiter issue in address fields Rafal Michalski
2011-08-26  7:24 ` Rafał Michalski [this message]
2011-09-27  9:47 ` [PATCH obexd 1/2] Refactoring address fields handled in vcard module Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E574A35.30106@comarch.pl \
    --to=rafal.michalski@comarch.pl \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).