linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: linux-bluetooth@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] hciattach: fix serial speed setting for wl1271
Date: Wed, 07 Sep 2011 12:26:12 +0200	[thread overview]
Message-ID: <4E6746C4.90903@visionsystems.de> (raw)
In-Reply-To: <4E64D1B4.9020300@visionsystems.de>

Am 05.09.2011 15:42, schrieb Yegor Yefremov:
> override speed setting if firmware script issues serial settings command,
> otherwise the value given in the firmware script will be overridden.
> 
> Example:
> 
> hciattach /dev/ttyO1 texas 115200
> 
> will fail, because /dev/ttyO1 will be opened with 115200 b/s, then
> the firmware script will set the buadrate to 3000000 b/s, after UART init
> hciattach.c will set the baudrate to 115200, so communication is broken.
> 
> The only correct way is to set both speeds:
> 
> hciattach -s 115200 /dev/ttyO1 texas 3000000
> 
> With this patch only initial speed must be specified. The former semantic
> will be preserved in case the firmware script doesn't provide serial
> settings action.
> 
> Tested with wl1271 and firmware TIInit_7.2.31.bts
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  tools/hciattach.c    |    2 +-
>  tools/hciattach.h    |    2 +-
>  tools/hciattach_ti.c |   19 +++++++++++--------
>  3 files changed, 13 insertions(+), 10 deletions(-)
> 

See this thread for more info: http://e2e.ti.com/support/low_power_rf/f/307/t/57254.aspx

  reply	other threads:[~2011-09-07 10:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 13:42 [PATCH] hciattach: fix serial speed setting for wl1271 Yegor Yefremov
2011-09-07 10:26 ` Yegor Yefremov [this message]
2011-09-27  9:26 ` Johan Hedberg
2011-10-17 12:24   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6746C4.90903@visionsystems.de \
    --to=yegor_sub1@visionsystems.de \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).