linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Gix <bgix@codeaurora.org>
To: Chen Ganir <chen.ganir@gmail.com>
Cc: Claudio Takahasi <claudio.takahasi@openbossa.org>,
	Vinicius Costa Gomes <vinicius.gomes@openbossa.org>,
	BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC] LE based Remote Name Request
Date: Sat, 19 Nov 2011 08:21:19 -0800	[thread overview]
Message-ID: <4EC7D77F.7060505@codeaurora.org> (raw)
In-Reply-To: <CAP2aRG+Wfvs-gEAjR5aKYx1FfMF69LmfMaHgRZnoxEbqUaYDGg@mail.gmail.com>

Hi Chen,

On 11/18/2011 9:28 PM, Chen Ganir wrote:
> On Sat, Nov 19, 2011 at 01:39, Brian Gix<bgix@codeaurora.org>  wrote:
>> Those are otherwise good points (not all devices will automatically start
>> advertising again) however ServiceChanged should never be attempted to be
>> read.  We should only obtain this via an Indication from the remote device,
>> and at any rate it is only shared with Trusted devices, so we would have to
>> be Bonded.
>>
>> However, I would definitely NOT try to re-read Name/Appearance at every
>> connection.  Those should definitely be cached, and not re-read unless we
>> get the ServiceChanged Indication.
>>
> ServiceChanged is irrelevant here. ServiceChanged will only notify you
> if the handles changed, not if the value changed. Name and appearance
> can and should be read, since we may get only the short name in the
> advertising data, and we wil need the full name. In addition, a device
> may change its name, and we will not be notified of this (GAP name
> characteristic does not notify/indicate). Name may change just like it
> does in BR/EDR.

I don't think we should do anything automatically on start-up.

If we know that we do not have the full name (if the Adv data has it 
flagged as "Partial") then we should of course fetch the full name from 
the characteristic.  However, if we get in the habit of re-reading data 
just because it *may* have changed, then we lose track of what LE is all 
about, which is minimization of over-the-air traffic.

If a particular high level app wants refresh the Name and/or Appearance, 
then of course which should provide that ability, but I might consider 
that App to be poorly written barring a compelling need, like perhaps an 
indication that it needs to be re-paired.  Single mode LE devices will 
generally be single mode because they want to limit these unneeded 
transactions.  LE Profiles are designed to not require Polling type 
activities, which a Name or Appearance refresh would be.

-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

      reply	other threads:[~2011-11-19 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 19:39 [RFC] LE based Remote Name Request Brian Gix
2011-11-18 22:08 ` Vinicius Costa Gomes
2011-11-18 22:30   ` Chen Ganir
2011-11-18 22:30   ` Claudio Takahasi
2011-11-18 23:39     ` Brian Gix
2011-11-19  5:28       ` Chen Ganir
2011-11-19 16:21         ` Brian Gix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC7D77F.7060505@codeaurora.org \
    --to=bgix@codeaurora.org \
    --cc=chen.ganir@gmail.com \
    --cc=claudio.takahasi@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).