linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Gix <bgix@codeaurora.org>
To: "Ganir, Chen" <chen.ganir@ti.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: SMP Key distribution
Date: Mon, 05 Dec 2011 07:39:04 -0800	[thread overview]
Message-ID: <4EDCE598.20808@codeaurora.org> (raw)
In-Reply-To: <F0070FBC0FB3174D8D11444EB2D5B02643FFBB@DNCE02.ent.ti.com>

Hi Chen,

On 12/5/2011 1:02 AM, Ganir, Chen wrote:
> Hi.
>
> According to the SMP spec (Vol3, Part H, Appendix 5.3.4), keys are distributed in a specific order, where the slave first sends its LTK,EDIV, RAND , IRK, ADDR TYPE and signature key (according to the key distribution parameter. Only when the slave completes its key distribution, the master then starts distributing its own keys (same order, according to the master key distribution options). In the current implementation in the smp.c, it seems that we start distributing our keys too early (after the MASTER IDENTIFICATION message, ignoring the possibility of Addr type and signature keys which may come from the slave. This may break the key distribution phase.
>
> Has anyone seen this or has anything to comment on that ?
>

Currently the SMP code is hard coded to only support a single key, which 
is the LTK+MID from the Slave to the Master.

You are correct that we will need to ensure that all of the keys are 
handled correctly, including ensuring proper order, once we add support 
for additional key distribution.  At the moment though, that is a moot 
question.


-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

  reply	other threads:[~2011-12-05 15:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05  9:02 SMP Key distribution Ganir, Chen
2011-12-05 15:39 ` Brian Gix [this message]
2011-12-05 15:48   ` Ganir, Chen
2011-12-05 17:44     ` Brian Gix
2011-12-06  7:43       ` Ganir, Chen
2011-12-06 18:16         ` Brian Gix
2011-12-07  0:54           ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCE598.20808@codeaurora.org \
    --to=bgix@codeaurora.org \
    --cc=chen.ganir@ti.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).