From: Chanyeol Park <chanyeol.park@samsung.com>
To: linux-bluetooth@vger.kernel.org
Cc: 서호철 <hocheol.seo@samsung.com>, 편도현 <dh79.pyun@samsung.com>
Subject: How about adding Dbus log in gdbus?
Date: Sat, 10 Dec 2011 00:39:05 +0900 [thread overview]
Message-ID: <4EE22B99.10600@samsung.com> (raw)
Hello
How about adding dbus log in gdbus when we get method call from the
remote peer(application)?
Personally It could be very useful for begginer.Based on it many people
could understand
call procedure easily. As far as I know this was removed when bluez
3.xx. but compared to the days,
recently many dbus APIs have been introduced.
But I know it is relatetd to many projects(bluez,obexd,connman,ofono).
So we need to consider a few things such as dependency managing and user
preference.
because curren gdbus does not have dependency with log.c/log.h.
Is there good idea about this?
BR
Chanyeol Park.
diff --git a/gdbus/object.c b/gdbus/object.c
index 8bc12f5..ac7f448 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -33,9 +33,7 @@
#include "gdbus.h"
-#define info(fmt...)
-#define error(fmt...)
-#define debug(fmt...)
+#include "log.h"
struct generic_data {
unsigned int refcount;
@@ -444,6 +442,9 @@ static DBusHandlerResult
generic_message(DBusConnection *connection,
iface->user_data) == TRUE)
return DBUS_HANDLER_RESULT_HANDLED;
+ DBG("%s: %s.%s()",dbus_message_get_path(message),
+ iface->name,method->name);
+
return process_message(connection, message, method,
iface->user_data);
}
Thanks
Chanyeol Park
next reply other threads:[~2011-12-09 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 15:39 Chanyeol Park [this message]
2011-12-09 21:08 ` How about adding Dbus log in gdbus? Luiz Augusto von Dentz
2011-12-12 12:57 ` Chanyeol Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE22B99.10600@samsung.com \
--to=chanyeol.park@samsung.com \
--cc=dh79.pyun@samsung.com \
--cc=hocheol.seo@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).