From: Brian Gix <bgix@codeaurora.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH-v8 1/2] Bluetooth: Add MITM mechanism to LE-SMP
Date: Wed, 21 Dec 2011 15:56:06 -0800 [thread overview]
Message-ID: <4EF27216.4030905@codeaurora.org> (raw)
In-Reply-To: <1324511576.1965.186.camel@aeonflux>
Hi Marcel,
On 12/21/2011 3:52 PM, Marcel Holtmann wrote:
> Hi Brian,
>
>> +static const u8 gen_method[5][5] = {
>
> can the tab between u8 and gen_method please go away.
>
>> + { JUST_WORKS, JUST_CFM, REQ_PASSKEY, JUST_WORKS, REQ_PASSKEY },
>> + { JUST_WORKS, JUST_CFM, REQ_PASSKEY, JUST_WORKS, REQ_PASSKEY },
>> + { CFM_PASSKEY, CFM_PASSKEY, REQ_PASSKEY, JUST_WORKS, CFM_PASSKEY },
>> + { JUST_WORKS, JUST_CFM, JUST_WORKS, JUST_WORKS, JUST_CFM },
>> + { CFM_PASSKEY, CFM_PASSKEY, REQ_PASSKEY, JUST_WORKS, OVERLAP },
>> +};
>
> Can you make sure all elements are aligned like you had it before. So
> the table becomes readable. If you go over 80 chars here then that is
> fine. So be it.
>
Sure. Sorry, I misunderstood which tab you were referring to last time.
> For the rest I am happy with it.
>
> Acked-by: Marcel Holtmann<marcel@holtmann.org>
>
--
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2011-12-21 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 22:08 [PATCH-v8 0/2] Bluetooth: Add MITM protection to LE-SMP Brian Gix
2011-12-21 22:08 ` [PATCH-v8 1/2] Bluetooth: Add MITM mechanism " Brian Gix
2011-12-21 23:52 ` Marcel Holtmann
2011-12-21 23:56 ` Brian Gix [this message]
2011-12-21 22:08 ` [PATCH-v8 2/2] Bluetooth: Add SMP to User Passkey and Confirm Brian Gix
2011-12-21 23:54 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF27216.4030905@codeaurora.org \
--to=bgix@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).