Re: [PATCH-v1 1/1] Bluetooth: Incorrect address while storing LTK.

[Brian Gix <bgix@codeaurora.org>]

Hi Hemant,

On 12/22/2011 9:37 PM, Hemant Gupta wrote:
> This patch fixes incorrect address storage while storing
> Long Term Key for LE Devices using SMP (Security Manager Protocol).
> The address stored should be of remote device and not of source device.
>
> Signed-off-by: Hemant Gupta<hemant.gupta@stericsson.com>
> ---
>   net/bluetooth/smp.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
> index 9fea4bf..32c47de 100644
> --- a/net/bluetooth/smp.c
> +++ b/net/bluetooth/smp.c
> @@ -820,7 +820,7 @@ static int smp_cmd_master_ident(struct l2cap_conn *conn, struct sk_buff *skb)
>
>   	skb_pull(skb, sizeof(*rp));
>
> -	hci_add_ltk(conn->hcon->hdev, 1, conn->src, smp->smp_key_size,
> +	hci_add_ltk(conn->hcon->hdev, 1, conn->dst, smp->smp_key_size,
>   						rp->ediv, rp->rand, smp->tk);
>
>   	smp_distribute_keys(conn, 1);

I agree that this is a bug, and that this is the correct fix.


-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum