From: Rene Herman <rene.herman@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Gustavo Padovan <padovan@profusion.mobi>,
Andre Guedes <andre.guedes@openbossa.org>,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [bluetooth] linux-3.x regression (bisected)
Date: Wed, 28 Dec 2011 18:24:18 +0100 [thread overview]
Message-ID: <4EFB50C2.4070600@gmail.com> (raw)
In-Reply-To: <1325090923.1965.282.camel@aeonflux>
On 28-12-11 17:48, Marcel Holtmann wrote:
> The correct patch would be something like this:
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 919e3c0..b6eb9c5 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -711,7 +711,8 @@ static void hci_cc_read_local_ext_features(struct hci_dev *h
> if (rp->status)
> return;
>
> - memcpy(hdev->extfeatures, rp->features, 8);
> + if (rp->page == 1)
> + memcpy(hdev->extfeatures, rp->features, 8);
>
> hci_req_complete(hdev, HCI_OP_READ_LOCAL_EXT_FEATURES, rp->status);
> }
>
> The current patch is actually fully broken anyway. So besides switching
> LE on when requesting page 0, you will also switch it off when
> requesting any other page and it accidentally returns 0x00 since we
> unconditionally overwrite it.
Don't know anything about pages, but... I can confirm that the above
works for me as well.
Rene.
next prev parent reply other threads:[~2011-12-28 17:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EF3BACA.1080405@gmail.com>
2011-12-27 17:22 ` [bluetooth] linux-3.x regression (bisected) Andre Guedes
2011-12-27 19:38 ` Rene Herman
2011-12-27 20:30 ` Gustavo Padovan
2011-12-27 22:19 ` Rene Herman
2011-12-28 1:22 ` Gustavo Padovan
2011-12-28 1:28 ` Gustavo Padovan
2011-12-28 1:53 ` Rene Herman
2011-12-28 1:57 ` Rene Herman
2011-12-28 15:52 ` Gustavo Padovan
2011-12-28 16:04 ` David Herrmann
2011-12-28 16:16 ` Gustavo Padovan
2011-12-28 16:48 ` Marcel Holtmann
2011-12-28 17:24 ` Rene Herman [this message]
2011-12-28 22:17 ` Rene Herman
2011-12-28 23:07 ` Marcel Holtmann
2011-12-29 0:22 ` Rene Herman
2012-01-04 12:04 ` Rene Herman
2012-01-04 14:16 ` Andre Guedes
2012-01-04 15:12 ` Rene Herman
2011-12-28 16:54 ` Rene Herman
2011-12-28 17:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFB50C2.4070600@gmail.com \
--to=rene.herman@gmail.com \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).