From: Daniel Wagner <wagi@monom.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3] Bluetooth: Fix l2cap conn failures for ssp devices
Date: Wed, 04 Jan 2012 11:22:22 +0100 [thread overview]
Message-ID: <4F04285E.1070500@monom.org> (raw)
In-Reply-To: <1312921615.2261.1.camel@THOR>
Hi Peter,
On 09.08.2011 22:26, Peter Hurley wrote:
> Commit 330605423c fixed l2cap conn establishment for non-ssp remote
> devices by not setting HCI_CONN_ENCRYPT_PEND every time conn security
> is tested (which was always returning failure on any subsequent
> security checks).
>
> However, this broke l2cap conn establishment for ssp remote devices
> when an ACL link was already established at SDP-level security. This
> fix ensures that encryption must be pending whenever authentication
> is also pending.
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
git am complaines:
Applying: Bluetooth: Fix l2cap conn failures for ssp devices
/home/wagi/src/bluetooth-next/.git/rebase-apply/patch:18: trailing whitespace.
/home/wagi/src/bluetooth-next/.git/rebase-apply/patch:19: trailing whitespace.
/* encrypt must be pending if auth is also pending */
/home/wagi/src/bluetooth-next/.git/rebase-apply/patch:20: trailing whitespace.
set_bit(HCI_CONN_ENCRYPT_PEND, &conn->pend);
/home/wagi/src/bluetooth-next/.git/rebase-apply/patch:21: trailing whitespace.
But it fixes the problem I was debugging. From what I have
learned in the last two days I would say it is also the right fix :)
Tested-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
cheers,
daniel
next prev parent reply other threads:[~2012-01-04 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 20:26 [PATCH v3] Bluetooth: Fix l2cap conn failures for ssp devices Peter Hurley
2012-01-04 10:22 ` Daniel Wagner [this message]
2012-01-09 8:30 ` Daniel Wagner
2012-01-11 11:26 ` Johan Hedberg
2012-01-16 19:37 ` Peter Hurley
2012-01-17 8:27 ` Johan Hedberg
2012-01-17 12:34 ` Peter Hurley
2012-02-01 22:22 ` Luiz Augusto von Dentz
2012-02-02 0:12 ` Marcel Holtmann
2012-02-02 0:26 ` Johan Hedberg
2012-02-02 9:36 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F04285E.1070500@monom.org \
--to=wagi@monom.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).