Re: rfcomm & encryption

[Daniel Wagner <wagi@monom.org>]

Hi Szymon,

On 04.01.2012 09:10, Szymon Janc wrote:
> Hi,
> 
>> so we are establishing the connection with security level of SDP only
>> hence no encryption required. Which is the only exception to run without
>> encryption when using SSP.
>>
>> Since we do not disconnected in between SDP and RFCOMM channels, we have
>> to do a security level upgrade here. And for some reason that gets
>> triggered, but does not force encryption to be switched on.
>>
>> With SSP enabled you should always switch on encryption when getting
>> authentication complete event. Actually generally speaking you should
>> always switch on encryption after authentication. Otherwise the
>> authentication is rather pointless anyway.
>>
>> Look at commit d7556e20, then this code got re-ordered. It does not look
>> correct to me anymore. We might need to redo the whole auth and encrypt
>> callback handling.
> 
> Some time ago there was a patch from Peter Hurley that should fixed that issue.
> I've just noticed that for some reason it was not merged upstream..
> (we use it in our own branch for some time already)
> 
> [PATCH v3] Bluetooth: Fix l2cap conn failures for ssp devices
> http://www.spinics.net/lists/linux-bluetooth/msg15312.html

Thanks for the pointer. This patch fixes the problem.

cheers,
daniel