From: "Arend van Spriel" <arend@broadcom.com>
To: "Andrei Emeltchenko" <andrei.emeltchenko.news@gmail.com>,
"David Miller" <davem@davemloft.net>,
dh.herrmann@googlemail.com, gustavo@padovan.org,
linville@tuxdriver.com, linux-bluetooth@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix coding style
Date: Mon, 7 May 2012 12:06:17 +0200 [thread overview]
Message-ID: <4FA79E99.9020900@broadcom.com> (raw)
In-Reply-To: <20120507082945.GB19002@aemeltch-MOBL1>
On 05/07/2012 10:29 AM, Andrei Emeltchenko wrote:
> Hi Arend,
>
> On Mon, May 07, 2012 at 10:21:44AM +0200, Arend van Spriel wrote:
>> On 05/07/2012 10:14 AM, Andrei Emeltchenko wrote:
>>>> They don't. All the examples you'll find are of the form:
>>>>>
>>>>> if (a &&
>>>>> b)
>>>>>
>>>>> not:
>>>>>
>>>>> if (a &&
>>>>> b)
>>> Actually it does not look like this, otherwise "b" would be placed in the
>>> same line, don't it?
>>
>> Let me rephrase Dave's remark so you may understand:
>>
>> if (a_has_to_be_long_enough_to_make_you_understand &&
>> you_do_not_care_about_code_readability)
>>
>> and not:
>> if (a_has_to_be_long_enough_to_make_you_understand &&
>> you_do_not_care_about_code_readability)
>
> You seems to forgot to reply to the main question about Codying Style.
>
> Best regards
> Andrei Emeltchenko
True. But you explicitly addressed that one to David. The alignment rule
is indeed not stated in CodingStyle document, but using a seemingly
random amount of tabs is obviously not improving readability. I suppose
the alignment rule with an example could be added to the CodingStyle.
Gr. AvS
next prev parent reply other threads:[~2012-05-07 10:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:59 [PATCH] Bluetooth: Fix coding style Gustavo Padovan
2012-05-06 16:02 ` Marcel Holtmann
2012-05-06 16:36 ` David Miller
2012-05-06 17:46 ` David Herrmann
2012-05-06 18:53 ` David Miller
2012-05-07 8:14 ` Andrei Emeltchenko
2012-05-07 8:21 ` Arend van Spriel
2012-05-07 8:29 ` Andrei Emeltchenko
2012-05-07 10:06 ` Arend van Spriel [this message]
2012-05-07 15:52 ` David Miller
2012-05-07 19:49 ` Lucas De Marchi
2012-05-07 20:06 ` David Miller
2012-05-07 20:14 ` Arend van Spriel
2012-05-07 21:33 ` Marcel Holtmann
2012-05-07 21:41 ` David Miller
2012-05-07 17:06 ` Marcel Holtmann
2012-05-07 17:55 ` David Miller
2012-05-07 21:22 ` Marcel Holtmann
2012-05-07 23:24 ` Joe Perches
2012-05-07 19:40 ` Lucas De Marchi
2012-05-07 15:24 ` Gustavo Padovan
2012-05-07 15:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA79E99.9020900@broadcom.com \
--to=arend@broadcom.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=davem@davemloft.net \
--cc=dh.herrmann@googlemail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).