From: Minho Ban <mhban@samsung.com>
To: Chanyeol Park <chanyeol.park@samsung.com>
Cc: Gustavo Padovan <gustavo@padovan.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] Bluetooth: prevent double l2cap_chan_destroy
Date: Wed, 23 May 2012 10:39:34 +0900 [thread overview]
Message-ID: <4FBC3FD6.6050704@samsung.com> (raw)
In-Reply-To: <4FBB8544.3040408@samsung.com>
On 05/22/2012 09:23 PM, Chanyeol Park wrote:
> Hi
>
> On 2012년 05월 22일 11:50, Minho Ban wrote:
>> @@ -1343,10 +1343,10 @@ static void l2cap_conn_del(struct hci_conn *hcon, int err)
>> l2cap_chan_lock(chan);
>>
>> l2cap_chan_del(chan, err);
>> + chan->ops->close(chan->data);
>>
>> l2cap_chan_unlock(chan);
>>
>> - chan->ops->close(chan->data);
>> l2cap_chan_put(chan);
>> }
> I think this patch does not make sense Because inside chan->ops->close() "chan" could be freed in the l2cap_chan_destroy().
>
I agree, thanks for pointing out.
prev parent reply other threads:[~2012-05-23 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 0:56 [RFC/PATCH] Bluetooth: prevent double l2cap_chan_destroy Minho Ban
2012-05-21 16:21 ` Gustavo Padovan
2012-05-22 2:50 ` Minho Ban
2012-05-22 12:23 ` Chanyeol Park
2012-05-23 1:39 ` Minho Ban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC3FD6.6050704@samsung.com \
--to=mhban@samsung.com \
--cc=chanyeol.park@samsung.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).