From: Daniel Wagner <wagi@monom.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v1 3/3] device: Ignore DUN if PAN is present
Date: Thu, 24 May 2012 15:29:19 +0200 [thread overview]
Message-ID: <4FBE37AF.9000801@monom.org> (raw)
In-Reply-To: <20120524102120.GC23856@x220>
Hi Johan,
On 24.05.2012 12:21, Johan Hedberg wrote:
> Hi Daniel,
>
> On Thu, May 24, 2012, Daniel Wagner wrote:
>> --- a/src/device.c
>> +++ b/src/device.c
>> @@ -63,6 +63,8 @@
>> #include "btio.h"
>> #include "attrib-server.h"
>> #include "attrib/client.h"
>> +#include "network/common.h"
>> +#include "serial/common.h"
>
> I don't really like the idea of creating dependencies from the core
> daemon (src/*) to plugin or profile directories. Any other (clean) way
> we could avoid this?
Okay, good point.
I see that update_sevice() already uses PNP_UUID which happens to be
defined in src/storage.h. Maybe we could move all *_UUID into one header
file into the core? Would that be an option?
cheers,
daniel
prev parent reply other threads:[~2012-05-24 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 10:00 [PATCH v1 0/3] Prefer PAN over DUN Daniel Wagner
2012-05-24 10:00 ` [PATCH v1 1/3] main: Add IngoreDUN configuration switch Daniel Wagner
2012-05-24 10:20 ` Johan Hedberg
2012-05-24 17:41 ` Vinicius Costa Gomes
2012-05-30 9:33 ` Daniel Wagner
2012-05-24 10:00 ` [PATCH v1 2/3] serial: Add DUN_GW_UUID Daniel Wagner
2012-05-24 10:00 ` [PATCH v1 3/3] device: Ignore DUN if PAN is present Daniel Wagner
2012-05-24 10:21 ` Johan Hedberg
2012-05-24 13:29 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE37AF.9000801@monom.org \
--to=wagi@monom.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).