[PATCH 1/1] build: Remove gstreamer pkg config warning

[PATCH 1/1] build: Remove gstreamer pkg config warning

[chanyeol.park]

From: Chan-yeol Park <chanyeol.park@samsung.com>

GSTREAMER is not mandatory option when bluez build.
---
 acinclude.m4 |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 6505ad3..6e3eb83 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -106,8 +106,9 @@ AC_DEFUN([AC_PATH_GLIB], [
 ])
 
 AC_DEFUN([AC_PATH_GSTREAMER], [
-	PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10, gstreamer_found=yes,
-				AC_MSG_WARN(GStreamer library version 0.10.30 or later is required);gstreamer_found=no)
+	PKG_CHECK_MODULES(GSTREAMER,
+                        gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10,
+                        gstreamer_found=yes, gstreamer_found=no)
 	AC_SUBST(GSTREAMER_CFLAGS)
 	AC_SUBST(GSTREAMER_LIBS)
 	GSTREAMER_PLUGINSDIR=`$PKG_CONFIG --variable=pluginsdir gstreamer-0.10`
-- 
1.7.9.5

Re: [PATCH 1/1] build: Remove gstreamer pkg config warning

[Marcel Holtmann]

Hi Chan-yeol,

> From: Chan-yeol Park <chanyeol.park@samsung.com>
> 
> GSTREAMER is not mandatory option when bluez build.
> ---
>  acinclude.m4 |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 6505ad3..6e3eb83 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -106,8 +106,9 @@ AC_DEFUN([AC_PATH_GLIB], [
>  ])
>  
>  AC_DEFUN([AC_PATH_GSTREAMER], [
> -	PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10, gstreamer_found=yes,
> -				AC_MSG_WARN(GStreamer library version 0.10.30 or later is required);gstreamer_found=no)
> +	PKG_CHECK_MODULES(GSTREAMER,
> +                        gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10,
> +                        gstreamer_found=yes, gstreamer_found=no)
>  	AC_SUBST(GSTREAMER_CFLAGS)
>  	AC_SUBST(GSTREAMER_LIBS)
>  	GSTREAMER_PLUGINSDIR=`$PKG_CONFIG --variable=pluginsdir gstreamer-0.10`

as discussed during the BlueZ meeting, we will be removing GStreamer
support for BlueZ and submit it GStreamer. The prerequisite of the
standalone SBC library has been released yesterday. 

So NAK on this patch since soon it will not be needed anymore.

Regards

Marcel

Re: [PATCH 1/1] build: Remove gstreamer pkg config warning

[Chanyeol Park]

Hi Marcel

On 2012년 08월 01일 14:01, Marcel Holtmann wrote:
>
> as discussed during the BlueZ meeting, we will be removing GStreamer
> support for BlueZ and submit it GStreamer. The prerequisite of the
> standalone SBC library has been released yesterday.
>
> So NAK on this patch since soon it will not be needed anymore.
>
> Regards
>
> Marcel
Understood.

Thanks for explanation.

Yesterday I saw your SBC announce.

If I want to send a patch about SBC,
could we use the same account(linux-bluetooth account)?

As far as I expect,
it's not easy to recognize patches on the same account.


Regards
Chanyeol