linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Gustavo Padovan <gustavo@padovan.org>,
	linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	linux-kernel@vger.kernel.org, John Hommel <john.hommel@hp.com>
Subject: Re: [PATCH v2] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1]
Date: Wed, 08 Aug 2012 10:37:57 +0200	[thread overview]
Message-ID: <50222565.5060603@suse.cz> (raw)
In-Reply-To: <20120806184047.GD3146@joana>

On 6.8.2012 20:40, Gustavo Padovan wrote:
> Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Date:   Mon Aug 6 15:36:49 2012 -0300
> 
>     Bluetooth: Use USB_VENDOR_AND_INTERFACE_INFO() for Broadcom devices
>     
>     Many Broadcom devices has a vendor specific devices class, with this rule
>     we match all existent and future controllers with this behavior.
>     
>     Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index cef3bac..504231e 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -104,6 +104,9 @@ static struct usb_device_id btusb_table[] = {
>         /* Foxconn - Hon Hai */
>         { USB_DEVICE(0x0489, 0xe033) },
>  
> +       /*Broadcom devices with vendor specific id */
> +       { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) },

Hi Gustavo,

Yes, this works. Well, I don't posses the card personally, but a helpful
person at HP confirmed that the btusb driver with this patch works with
the new card. So you can add

  Tested-by: John Hommel <john.hommel@hp.com>

BTW, the following ID can also be removed after adding the above match:

	{ USB_DEVICE(0x0a5c, 0x21e1) },
	{ USB_DEVICE(0x0a5c, 0x21e3) },
	{ USB_DEVICE(0x0a5c, 0x21e6) },
	{ USB_DEVICE(0x0a5c, 0x21e8) },
	{ USB_DEVICE(0x0a5c, 0x21f3) },

Thanks,
Michal

      reply	other threads:[~2012-08-08  8:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 21:21 [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1] Michal Marek
2012-07-27 23:29 ` Marcel Holtmann
2012-07-31 13:47   ` [PATCH v2] " Michal Marek
2012-08-06 18:40     ` Gustavo Padovan
2012-08-08  8:37       ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50222565.5060603@suse.cz \
    --to=mmarek@suse.cz \
    --cc=gustavo@padovan.org \
    --cc=john.hommel@hp.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).