linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Danis <frederic.danis@linux.intel.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] client: Add parameters to get message in map module
Date: Fri, 31 Aug 2012 09:23:36 +0200	[thread overview]
Message-ID: <50406678.5040002@linux.intel.com> (raw)
In-Reply-To: <CABBYNZKgTHcPDGOj4Qi+6=XDqFK6g9c-zZ-tANKCjLQqhKKjQw@mail.gmail.com>

Hello Luiz,

On 30/08/2012 17:21, Luiz Augusto von Dentz wrote:
>> +       apparam = g_obex_apparam_set_uint8(NULL, MAP_AP_ATTACHMENT, 0);
>> +       apparam = g_obex_apparam_set_uint8(apparam, MAP_AP_CHARSET, 1);
>> +       len = g_obex_apparam_encode(apparam, buf, sizeof(buf));
>> +
>> +       obc_transfer_set_params(transfer, buf, len);
>> +
>> +       g_obex_apparam_free(apparam);
>> +
>>          if (!obc_session_queue(msg->data->session, transfer, NULL, NULL, &err))
>>                  goto fail;
>>
>> --
>> 1.7.9.5
>
> I have a pending patchset to address this, basically adding filters
> parameters so the application can enable what this parameters should
> be. Btw, Im confused why are you setting attachment as type uint8, the
> spec says it should assume "On" or "Off", which normally means it is
> of string type.
>

I sent this as those parameters are needed to be able to retrieve 
message on Samsung GT-I9300.
Forgot it as you have more complete patchset.

Attachment parameter is defined as a byte in chapter 6.3.1 of the MAP 
spec (page 65, bitmask with 0="OFF" and 1="ON").


-- 
Frederic Danis                            Open Source Technology Center
frederic.danis@intel.com                              Intel Corporation


      reply	other threads:[~2012-08-31  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  9:39 [PATCH obexd] client: Add parameters to get message in map module Frédéric Danis
2012-08-30 15:21 ` Luiz Augusto von Dentz
2012-08-31  7:23   ` Frederic Danis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50406678.5040002@linux.intel.com \
    --to=frederic.danis@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).