From: Chen Ganir <chen.ganir@ti.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2] gatt: Delay D-Bus reply on char discovery
Date: Tue, 11 Sep 2012 15:22:17 +0300 [thread overview]
Message-ID: <504F2CF9.7060900@ti.com> (raw)
In-Reply-To: <CAJdJm_OZZ+SrYdfbpqy+yFmppx9xAs-YMmDtn3PzQbU1JD_pOA@mail.gmail.com>
Anderson,
On 09/11/2012 02:44 PM, Anderson Lizardo wrote:
> Hi Chen,
>
> On Tue, Sep 11, 2012 at 4:47 AM, <chen.ganir@ti.com> wrote:
>> From: Chen Ganir <chen.ganir@ti.com>
>>
>> Delay sending the D-Bus reply for the discover_characteristics
>> command. The D-Bus reply for characteristics is sent before all
>> the relevant characteristic information is gathered. This can
>> cause problems, when trying to get characteristic information too
>> soon. This patch moves the D-Bus reply to the end of the char
>> discovery process. Only after all descriptors are discovered and
>> read, the D-Bus reply is sent.
>> ---
>
> I see you populate chr->descriptors, but I can't find where the list
> is actually used. Do you plan to use this information in some other
> patch?
>
> Regards,
>
The plan is to replace characteristic::format, and add CCC, SCC and any
other descriptor we find in the future to this list. This way we have a
unified list of descriptors and the data contained in them. This is
already done in some patches i already have, which rely on this patch.
Next patch set includes notification/indication implementation to the
D-Bus API (Auto registration to notification/indication if CCC is found).
--
BR,
Chen Ganir
next prev parent reply other threads:[~2012-09-11 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 8:47 [PATCH v2] gatt: Delay D-Bus reply on char discovery chen.ganir
2012-09-11 11:44 ` Anderson Lizardo
2012-09-11 12:22 ` Chen Ganir [this message]
2012-09-11 12:27 ` Anderson Lizardo
2012-09-11 12:36 ` Chen Ganir
2012-09-21 13:19 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F2CF9.7060900@ti.com \
--to=chen.ganir@ti.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).