From: Chen Ganir <chen.ganir@ti.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3 09/10] battery: Add support for notifications
Date: Thu, 20 Sep 2012 14:00:47 +0300 [thread overview]
Message-ID: <505AF75F.6080509@ti.com> (raw)
In-Reply-To: <CAJdJm_P07N-VwgnHy=1m3D68086dP9fFy5AmkhZC_3b4d2xpmg@mail.gmail.com>
Anderson,
On 09/20/2012 01:54 PM, Anderson Lizardo wrote:
> Hi Chen,
>
> On Thu, Sep 20, 2012 at 4:27 AM, <chen.ganir@ti.com> wrote:
>> @@ -140,6 +156,18 @@ static void process_batteryservice_char(struct characteristic *ch)
>> }
>> }
>>
>> +static void batterylevel_enable_notify_cb(guint8 status, const guint8 *pdu,
>> + guint16 len, gpointer user_data)
>> +{
>> + struct characteristic *ch = (struct characteristic *)user_data;
>
> Casting above seems unnecessary (gpointer is typedef to void*).
>
I'll change that.
>> +
>> + if (status != 0) {
>> + error("Could not enable batt level notification.");
>> + ch->canNotify = FALSE;
>
> This camelCase is inconsistent with other struct fields on the same file.
>
Will be changed.
>> + process_batteryservice_char(ch);
>> + }
>> +}
>> +
>> static gint device_battery_cmp(gconstpointer a, gconstpointer b)
>> {
>> const struct characteristic *ch = a;
>
> Regards,
>
Thanks !
--
BR,
Chen Ganir
next prev parent reply other threads:[~2012-09-20 11:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 8:27 [PATCH v3 00/10] Implement Generic battery and LE Battery client chen.ganir
2012-09-20 8:27 ` [PATCH v3 01/10] battery: Add generic device battery documentation chen.ganir
2012-09-20 8:27 ` [PATCH v3 02/10] battery: Implement Generic device battery chen.ganir
2012-09-20 8:27 ` [PATCH v3 03/10] battery: Add GATT Battery Client Service skeleton chen.ganir
2012-09-20 8:27 ` [PATCH v3 04/10] battery: Add client connection logic chen.ganir
2012-09-20 8:27 ` [PATCH v3 05/10] battery: Discover Characteristic Descriptors chen.ganir
2012-09-20 8:27 ` [PATCH v3 06/10] battery: Get Battery ID chen.ganir
2012-09-20 10:46 ` Anderson Lizardo
2012-09-20 11:03 ` Chen Ganir
2012-09-20 8:27 ` [PATCH v3 07/10] battery: Add Battery to device chen.ganir
2012-09-20 8:27 ` [PATCH v3 08/10] battery: Read Battery level characteristic chen.ganir
2012-09-20 8:27 ` [PATCH v3 09/10] battery: Add support for notifications chen.ganir
2012-09-20 10:54 ` Anderson Lizardo
2012-09-20 11:00 ` Chen Ganir [this message]
2012-09-20 8:27 ` [PATCH v3 10/10] battery: Support persistent battery level chen.ganir
2012-09-20 10:56 ` [PATCH v3 00/10] Implement Generic battery and LE Battery client Anderson Lizardo
2012-09-20 11:04 ` Chen Ganir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505AF75F.6080509@ti.com \
--to=chen.ganir@ti.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).