linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen Ganir <chen.ganir@ti.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v3 00/10] Implement Generic battery and LE Battery client
Date: Thu, 20 Sep 2012 14:04:10 +0300	[thread overview]
Message-ID: <505AF82A.3060601@ti.com> (raw)
In-Reply-To: <CAJdJm_MhZwRyD8JVsmm6QTWqhWh1x2FXkopTQqdmNy=td0aj8Q@mail.gmail.com>

Anderson,

On 09/20/2012 01:56 PM, Anderson Lizardo wrote:
> Hi Chen,
>
> On Thu, Sep 20, 2012 at 4:27 AM,  <chen.ganir@ti.com> wrote:
>> From: Chen Ganir <chen.ganir@ti.com>
>>
>> This patch set replaces previous patch sets which implemented the LE battery
>> GATT Client. This patch set implements a generic device battery D-Bus interface
>> that can be used to get remote device battery status using D-Bus. In addition,
>> This patch set also implements the GATT Battery client, which uses the generic
>> device battery to expose LE device battery status.
>>
>> see doc/battery-api.txt and doc/device-api.txt for more information.
>>
>> This is version 2 of the patch set, including multiple style and other comments
>> reported on the ML. This version is rebased on the latest code.
>
> Besides some minor style comments (found on this last round of
> review), patch set looks good to me.
>
> Regards,
>
Thanks for the review !

I'll wait and see if there are any more comments before i send the next 
patch set with fixes.


-- 
BR,
Chen Ganir


      reply	other threads:[~2012-09-20 11:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  8:27 [PATCH v3 00/10] Implement Generic battery and LE Battery client chen.ganir
2012-09-20  8:27 ` [PATCH v3 01/10] battery: Add generic device battery documentation chen.ganir
2012-09-20  8:27 ` [PATCH v3 02/10] battery: Implement Generic device battery chen.ganir
2012-09-20  8:27 ` [PATCH v3 03/10] battery: Add GATT Battery Client Service skeleton chen.ganir
2012-09-20  8:27 ` [PATCH v3 04/10] battery: Add client connection logic chen.ganir
2012-09-20  8:27 ` [PATCH v3 05/10] battery: Discover Characteristic Descriptors chen.ganir
2012-09-20  8:27 ` [PATCH v3 06/10] battery: Get Battery ID chen.ganir
2012-09-20 10:46   ` Anderson Lizardo
2012-09-20 11:03     ` Chen Ganir
2012-09-20  8:27 ` [PATCH v3 07/10] battery: Add Battery to device chen.ganir
2012-09-20  8:27 ` [PATCH v3 08/10] battery: Read Battery level characteristic chen.ganir
2012-09-20  8:27 ` [PATCH v3 09/10] battery: Add support for notifications chen.ganir
2012-09-20 10:54   ` Anderson Lizardo
2012-09-20 11:00     ` Chen Ganir
2012-09-20  8:27 ` [PATCH v3 10/10] battery: Support persistent battery level chen.ganir
2012-09-20 10:56 ` [PATCH v3 00/10] Implement Generic battery and LE Battery client Anderson Lizardo
2012-09-20 11:04   ` Chen Ganir [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505AF82A.3060601@ti.com \
    --to=chen.ganir@ti.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).