From: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 00/14] Thermometer watchers API change + fixes
Date: Thu, 27 Sep 2012 12:47:52 +0200 [thread overview]
Message-ID: <50642ED8.3090007@tieto.com> (raw)
In-Reply-To: <CAJdJm_N3g2YN32dUo4Af9zBnaVPAcTW5MgF9O-mXz8y_Dt23CQ@mail.gmail.com>
Hi Anderson,
On 09/25/2012 05:21 PM, Anderson Lizardo wrote:
> Hi Andrzej,
>
> On Tue, Sep 25, 2012 at 10:52 AM, Andrzej Kaczmarek
> <andrzej.kaczmarek@tieto.com> wrote:
>> Hi,
>>
>> Here's series of patches to move watchers from per-device to per-adapter
>> interface (basically the same as done for HRP, see other series of patches).
>> This applies to both final and intermediate temperature watchers - once
>> watcher is registered, all connected devices are setup to send measurement
>> notifications and the opposite when last watcher is unregistered.
>>
>> This major change is done in patches 1-6.
>>
>> Patches 7-11 contain some code and documentation refactoring, i.e. to
>> remove duplicated code.
>>
>> Patches 12-14 are trival coding style fixes.
>>
>> Unfortunately, I wasn't able to fully test this code due to lack of proper
>> thermometer device and sample device from CC2540 devkit does not quite
>> work as expected (e.g. I can see CCC is written properly when watcher is
>> registered but remote does not send any indications for unknown reason).
>
> Unfortunately, the thermometer demo app (at least on TI's BLE stack
> v1.1 installation) has several bugs. I haven't tested yet the latest
> release (1.2.1), which version are you using?
1.2 but downloaded 1.2.1 and thermometer demo app didn't change so it
still does not work.
> Do you have access to PTS? You could test with it as well.
I currently don't have BLE dongle for PTS but will test as soon as I
have one.
> Maybe we should consider implementing a simple Thermometer role in
> BlueZ for testing purposes. It is a relatively simple profile.
So you mean something like optional org.bluez.ThermometerSensor
interface on adapter, similar to what is done for reporter role for
Proximity?
BR,
Andrzej
next prev parent reply other threads:[~2012-09-27 10:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 14:52 [PATCH 00/14] Thermometer watchers API change + fixes Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 01/14] thermometer: Store thermometer devices per-adapter Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 02/14] thermometer: Register ThermometerManager interface on adapter path Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 03/14] thermometer: Move watcher logic to adapter interface Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 04/14] thermometer: Include remote device information in MeasurementReceived Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 05/14] thermometer: Update API document Andrzej Kaczmarek
2012-09-28 10:40 ` Johan Hedberg
2012-09-25 14:52 ` [PATCH 06/14] thermometer: Update test script Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 07/14] thermometer: Reformat MeasurementReceived description Andrzej Kaczmarek
2012-09-28 10:43 ` Johan Hedberg
2012-09-28 11:09 ` Santiago Carot
2012-09-28 11:27 ` Johan Hedberg
2012-09-25 14:52 ` [PATCH 08/14] thermometer: Update driver naming style Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 09/14] thermometer: Add constant definition for watcher interface name Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 10/14] thermometer: Add common function to write characteristics CCC Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 11/14] thermometer: Refactor processing of measurement characteristic value Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 12/14] thermometer: Fix whitespace Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 13/14] thermometer: Fix indentation Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 14/14] thermometer: Fix missing braces Andrzej Kaczmarek
2012-09-25 15:21 ` [PATCH 00/14] Thermometer watchers API change + fixes Anderson Lizardo
2012-09-27 10:47 ` Andrzej Kaczmarek [this message]
2012-09-27 12:03 ` Anderson Lizardo
2012-10-01 11:44 ` Andrzej Kaczmarek
2012-10-01 11:51 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50642ED8.3090007@tieto.com \
--to=andrzej.kaczmarek@tieto.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).