From: Chen Ganir <chen.ganir@ti.com>
To: <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v4 01/10] battery: Add generic device battery documentation
Date: Sun, 30 Sep 2012 08:57:36 +0200 [thread overview]
Message-ID: <5067ED60.1080202@ti.com> (raw)
In-Reply-To: <20120928105937.GA14450@x220>
Johan,
On 09/28/2012 12:59 PM, Johan Hedberg wrote:
> Hi Chen,
>
> On Mon, Sep 24, 2012, chen.ganir@ti.com wrote:
>> +BlueZ D-Bus Battery API description
>> +****************************************
>
> Please keep the "underline" consistent with the length of the text above
> it.
>
>> + Texas Instruments, Inc. <chen.ganir@ti.com>
>
> What's this supposed to be? If you want a copyright statement here then
> make it of the proper format. Author info is not needed as we have the
> AUTHORS file and the commit history.
>
Would you please specify what is the proper copyright message format ?
doc/adapter-api.txt, doc/health-api.txt have two different styles.
doc/oob-api.txt has a third style (AUTHOR <author@email> for COMPANY),
doc/media-api.txt for example does not have any copyright information.
In addition - you say author information is not required, yet all other
copyright messages contain this. Is this a new policy ? If so, please
specify the proper copyright message.
>> +Device Battery hierarchy
>> +=====================================
>
> Same thing with the consistency of the "underline"
>
Ok.
>> +Service org.bluez
>> +Interface org.bluez.Battery
>> +Object path [variable prefix]/{hci0,..}/dev_XX_XX_XX_XX_XX_XX/BATTYYYY
>> +YYYY is numeric value between 0 and 9999.
>
> I don't think you need a separate comment for the "YYY". We don't have
> that for the "XX" stuff either.
>
Ok.
>> + array{object} Batteries [readonly]
>
> I guess you should mark this with [experimental] since it'll be removed
> with the advent of ObjectManager.
>
What is the difference between the Batteries property and the services
or UUIDs property in device-api.txt ? Should all of them get marked with
experimental ?
> Johan
>
--
BR,
Chen Ganir
Texas Instruments
next prev parent reply other threads:[~2012-09-30 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 7:15 [PATCH v4 00/10] Implement Generic battery and LE Battery client chen.ganir
2012-09-24 7:15 ` [PATCH v4 01/10] battery: Add generic device battery documentation chen.ganir
2012-09-28 10:59 ` Johan Hedberg
2012-09-30 6:57 ` Chen Ganir [this message]
2012-09-30 10:56 ` Johan Hedberg
2012-09-24 7:15 ` [PATCH v4 02/10] battery: Implement Generic device battery chen.ganir
2012-09-24 7:15 ` [PATCH v4 03/10] battery: Add GATT Battery Client Service skeleton chen.ganir
2012-09-24 7:15 ` [PATCH v4 04/10] battery: Add client connection logic chen.ganir
2012-09-24 7:15 ` [PATCH v4 05/10] battery: Discover Characteristic Descriptors chen.ganir
2012-09-24 7:15 ` [PATCH v4 06/10] battery: Get Battery ID chen.ganir
2012-09-24 7:15 ` [PATCH v4 07/10] battery: Add Battery to device chen.ganir
2012-09-24 7:15 ` [PATCH v4 08/10] battery: Read Battery level characteristic chen.ganir
2012-09-24 7:15 ` [PATCH v4 09/10] battery: Add support for notifications chen.ganir
2012-09-24 7:15 ` [PATCH v4 10/10] battery: Support persistent battery level chen.ganir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5067ED60.1080202@ti.com \
--to=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).