From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Nick Pelly <npelly@google.com>
Cc: Ville Tervo <ville.tervo@nokia.com>,
Dave Young <hidave.darkstar@gmail.com>,
Bluettooth Linux <linux-bluetooth@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: Kernel panic in rfcomm_run - unbalanced refcount on rfcomm_session
Date: Fri, 19 Mar 2010 10:33:02 +0200 [thread overview]
Message-ID: <508e92ca1003190133m1e2769ev36430d3c3b28504@mail.gmail.com> (raw)
In-Reply-To: <35c90d961003082331p6798006do17d6178ae2840591@mail.gmail.com>
Hi,
On Tue, Mar 9, 2010 at 9:31 AM, Nick Pelly <npelly@google.com> wrote:
> On Mon, Mar 8, 2010 at 11:19 PM, Ville Tervo <ville.tervo@nokia.com> wrote:
>> Tervo Ville (Nokia-D/Helsinki) wrote:
>>>
>>> l2cap socket status might change while rfcomm is processing frames. And
>>> that makes rfcomm_process_rx to do double rfcomm_session_put() for incoming
>>> session reference. We cannot use sk_state.
>>>
>>> Could you try with this patch if it helps to your problems also? My OPP
>>> problems went away with this patch.
>>>
>>> I moved rfcomm_session_put() for incoming session to rfcomm_session_close
>>> in order to get more clear _hold()/_put() pairs.
>>>
>>>
>>
>> Any comments about the patch in previous mail?
>
> Your patch looks sane to me, although I know enough of the Bluez
> rfcomm state machine to know that I don't know it that well :)
We have tested this patch and it looks to be working. Shall we apply it?
Regards,
Andrei
next prev parent reply other threads:[~2010-03-19 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 5:04 Kernel panic in rfcomm_run - unbalanced refcount on rfcomm_session Nick Pelly
2010-02-18 7:15 ` Ville Tervo
2010-02-20 8:17 ` Dave Young
2010-02-21 21:00 ` Nick Pelly
2010-02-26 10:23 ` Ville Tervo
2010-03-09 7:19 ` Ville Tervo
2010-03-09 7:31 ` Nick Pelly
2010-03-19 8:33 ` Andrei Emeltchenko [this message]
2010-10-29 12:34 ` Simantini Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508e92ca1003190133m1e2769ev36430d3c3b28504@mail.gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=npelly@google.com \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).