Hi Christian,

On Wed, Mar 13, 2013 at 1:27 PM, Marcel Holtmann <marcel@holtmann.org> wrote:

Hi Christian,

>>> This allows applications to register for all different types
>>> of MAP event reports.
>>>
>>> In response to this call, the MSE should connect to the local MNS
>>> instance.
>>> ---
>>> doc/obex-api.txt   |  6 ++++
>>> obexd/client/map.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 92 insertions(+)
>> never ever intermix doc/ changes with actual code. You really need to learn on how to split patches properly. There is no reason at all that this are not two patches.
>>
>>
>>> diff --git a/doc/obex-api.txt b/doc/obex-api.txt
>>> index 759c4d8..ef5d85e 100644
>>> --- a/doc/obex-api.txt
>>> +++ b/doc/obex-api.txt
>>> @@ -651,6 +651,12 @@ Methods                void SetFolder(string name)
>>>                     Possible errors: org.bluez.obex.Error.InvalidArguments
>>>                                      org.bluez.obex.Error.Failed
>>>
>>> +           void RegisterNotifications(boolean)
>>> +
>>> +                   Register / unregister reception of notifications.
>>> +
>>> +                   Possible errors: org.bluez.obex.Error.InvalidArguments
>>> +                                    org.bluez.obex.Error.Failed

Why we are not doing this automatically? The application can opt out by not connecting to signals, but I see no reason why not to be connected to register the notification channel automatically when connecting the MAP session if the remote support it.

--
Luiz Augusto von Dentz