From: Chen Gang <gang.chen@asianux.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Gustavo Padovan <gustavo@padovan.org>,
David Herrmann <dh.herrmann@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
David Miller <davem@davemloft.net>,
andrei.emeltchenko@intel.com,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code.
Date: Thu, 09 May 2013 16:48:38 +0800 [thread overview]
Message-ID: <518B62E6.1040905@asianux.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1305091041140.23038@pobox.suse.cz>
On 05/09/2013 04:42 PM, Jiri Kosina wrote:
> On Wed, 8 May 2013, Chen Gang wrote:
>
>> >
>> > For NUL terminated string, need always let it ended by zero.
>> >
>> > Since have already called memcpy() to initialize 'ci', so need not
>> > redundent initializations.
>> >
>> > Better use ''if(session->hid) {} else if(session->input) {}'' instead
>> > of ''if(session->hid) {}; if(session->input) {};''
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Makes sense.
>
> Acked-by: Jiri Kosina <jkosina@suse.cz>
>
> Gustavo, going to take this, please?
>
> -- Jiri Kosina SUSE Labs
>
Thanks, and also help to fix the spelling: redundent -> redundant.
(if need let me send patch v3, please reply to tell me, thanks)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-09 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:50 [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy Chen Gang
2013-05-07 14:08 ` [Suggestion] Bluetooth: hidp: redundant initialization or issue for function hidp_copy_session Chen Gang
2013-05-07 19:37 ` David Herrmann
2013-05-08 1:50 ` Chen Gang
2013-05-07 19:31 ` [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy David Herrmann
2013-05-08 1:02 ` Chen Gang
2013-05-08 3:34 ` [PATCH v2] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code Chen Gang
2013-05-08 15:16 ` David Herrmann
2013-05-09 1:07 ` Chen Gang
2013-05-09 8:42 ` Jiri Kosina
2013-05-09 8:48 ` Chen Gang [this message]
2013-05-13 2:07 ` [PATCH v3] " Chen Gang
2013-05-17 7:04 ` Chen Gang
2013-05-20 21:52 ` Gustavo Padovan
2013-05-21 1:40 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518B62E6.1040905@asianux.com \
--to=gang.chen@asianux.com \
--cc=andrei.emeltchenko@intel.com \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=gustavo@padovan.org \
--cc=jkosina@suse.cz \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).