linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dean Jenkins <Dean_Jenkins@mentor.com>
To: Gianluca Anzolin <gianluca@sottospazio.it>
Cc: marcel@holtmann.org, gustavo@padovan.org,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix tty refcounting in rfcomm/tty.c
Date: Wed, 10 Jul 2013 09:17:27 +0100	[thread overview]
Message-ID: <51DD1897.5020408@mentor.com> (raw)
In-Reply-To: <20130709170502.GA32765@debian.seek.priv>

Hi Gianluca,

On 09/07/13 18:05, Gianluca Anzolin wrote:
> In net/bluetooth/rfcomm/tty.c the struct tty is used without proper
> refcounting. This leads to OOPS and panics triggered by the tty layer functions
> which are invoked after the struct tty has already been destroyed.
>
> This happens for example when the bluetooth connection is lost because the host
> goes down unexpectedly.
>
> The fix uses the tty_port_* helpers already in place.
>
> This patch depends on patch "Fix refcount leak in tty_port.c" already sent to
> linux-kernel. [0]
>
> Signed-off-by: Gianluca Anzolin <gianluca@sottospazio.it>
>
> [0] http://lkml.indiana.edu/hypermail/linux/kernel/1307.1/00600.html
>

Do you have any backtraces of the OOPS and panics ?

In which kernel did you discover the failure ?

What platform were you using, I mean x86, ARM or something else ?

Is this failure easy to reproduce ?

Did you use Bluez userland to control Bluetooth ?

In the failure case, what protocol or application was bound to the 
RFCOMM TTY ? I mean was it SLIP, minicom or something else ?

Thanks,

Regards,
Dean Jenkins
Mentor Graphics

  reply	other threads:[~2013-07-10  8:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 17:05 [PATCH 1/2] Fix tty refcounting in rfcomm/tty.c Gianluca Anzolin
2013-07-10  8:17 ` Dean Jenkins [this message]
2013-07-10  8:39   ` Mathias Hasselmann
2013-07-10 11:24     ` Gianluca Anzolin
2013-07-10  9:37   ` Gianluca Anzolin
2013-07-10 10:43     ` Gianluca Anzolin
2013-07-10 15:46 ` Gustavo Padovan
2013-07-10 16:24   ` Gianluca Anzolin
2013-07-10 16:55     ` Gustavo Padovan
2013-07-10 17:01       ` Gianluca Anzolin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DD1897.5020408@mentor.com \
    --to=dean_jenkins@mentor.com \
    --cc=gianluca@sottospazio.it \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).