Re: [PATCH v8 8/8] Bluetooth: Prevent transparent SCO on older devices

["Frédéric DALLEAU" <frederic.dalleau@linux.intel.com>]

Marcel, Vinicius,

Le 08/07/2013 21:25, Marcel Holtmann a écrit :
> Hi Fred,
>
> we should check for eSCO and transparent SCO support. We do need both. And we also need to figure out on how to handle the incoming situation correctly,
>
> Is the error ECONNABORTED a correct one.
>
> Regards
>
> Marcel
>

My understanding of Vinicius comment is that some adapters may not
support esco but still have transparent data support thanks to Setup
Sync Conn. Transparent data on these adapters can be supported for
cheap since the connection establishment would be the same.

If we choose to go for eSCO AND transparent SCO support, then these
adapters get unused features.

One possibility is to check for Setup Synchronous Connection command bit
instead of Esco feature bit. But that makes a ugly bunch of tests :
if cvsd is requested
    check esco feature bit.
if transparent data is requested
    check setup sync conn command bit and transparent data feature bit.

The only problem so far is that I have yet to see these adapters :)

About the error ECONNABORTED, it is what the patch does : abort a 
connection. It is not used for other purposes. If you really want to
change, I'm ok with EOPNOTSUPP, otherwise please suggest.

Regards,
Fred