linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frédéric DALLEAU" <frederic.dalleau@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] sco-tester: Update ECONNABORTED to EOPNOTSUPP
Date: Mon, 12 Aug 2013 10:34:39 +0200	[thread overview]
Message-ID: <52089E1F.60704@linux.intel.com> (raw)
In-Reply-To: <09231CA6-E5F3-453E-9479-68F08072893A@holtmann.org>

Hi Marcel,

> can we please have a proper thread on what error is appropriate to send  > from a socket interface when this situation happens. I see that
 > we are flipping errors, but my request to discuss this gets ignored.
>

I already gave my opinion previously. Let's recall it :"About the error 
ECONNABORTED, it is what the patch does : abort a connection. It is not 
used for other purposes. If you really want to change, I'm ok with 
EOPNOTSUPP, otherwise please suggest."

Regarding EOPNOTSUPP. Most use case are when a pointer in an interface 
is not implemented. We could consider that SetupSyncConn is not 
implemented in 2.0 adapter interfaces.


 > Please look for a good reference of the error code usage in other 
socket protocols or manpages

It is not obvious to find one good reference. But for example there is : 
Documentation/ioctl/hdio.txt:     EOPNOTSUPP    Hardware interface does 
not support bus power

Another option could be:
[ENODEV]
     No such device An attempt was made to apply an inappropriate 
function to a device; for example, trying to read a write-only device 
such as a printer.

BR,
Fred

  reply	other threads:[~2013-08-12  8:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 15:42 [PATCH 1/3] sco-tester: Update ECONNABORTED to EOPNOTSUPP Frédéric Dalleau
2013-08-09 15:42 ` [PATCH 2/3] sco-tester: Introduce adapter features Frédéric Dalleau
2013-09-09  8:33   ` Johan Hedberg
2013-09-09 12:54     ` Frédéric DALLEAU
2013-09-09 15:03       ` Johan Hedberg
2013-08-09 15:42 ` [PATCH 3/3] sco-tester: Test transparent data feature bit Frédéric Dalleau
2013-08-09 15:53 ` [PATCH 1/3] sco-tester: Update ECONNABORTED to EOPNOTSUPP Marcel Holtmann
2013-08-12  8:34   ` Frédéric DALLEAU [this message]
2013-08-12 23:22     ` Marcel Holtmann
2013-08-13 13:10       ` Frédéric DALLEAU
2013-09-02 15:53 ` Frédéric DALLEAU
2013-09-09  8:29 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52089E1F.60704@linux.intel.com \
    --to=frederic.dalleau@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).