From: Hans de Goede <hdegoede@redhat.com>
To: linux-bluetooth@vger.kernel.org
Subject: Possible problem with btusb suspend resume handling
Date: Wed, 09 Oct 2013 17:10:26 +0200 [thread overview]
Message-ID: <525571E2.50409@redhat.com> (raw)
Hi,
While reviewing all users of usb_anchor-s (because of some
usb_anchor fixes I've been writing), I noticed that btusb normally
puts to be transmitted urbs on an anchor called tx_anchor and then
submits them, unless suspended, then they are put on an anchor called
deferred without being submitted.
On resume any urbs on the deferred anchor get removed from the deferred
anchor, and submitted to the device.
But unlike other drivers which similar constructs, btusb does not
move put them on the tx_anchor when submitting then from the resume
handler.
So after a resume with deferred transmits, there will be tx urbs in
flight which are not anchored on the tx_anchor. I believe this is
a bug, but I don't know the code well enough to be sure.
Regards,
Hans
reply other threads:[~2013-10-09 15:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525571E2.50409@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox