From: Ravi Kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: linux-bluetooth@vger.kernel.org, Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH_v2 06/11] android/hid: Fill send data structure variables in hal-hidhost
Date: Fri, 08 Nov 2013 11:30:30 +0200 [thread overview]
Message-ID: <527CAF36.3050709@linux.intel.com> (raw)
In-Reply-To: <20131108091715.GA24795@x220.p-661hnu-f1>
Hi Johan,
On 11/08/2013 11:17 AM, Johan Hedberg wrote:
> Hi Ravi,
>
> On Fri, Nov 08, 2013, Ravi kumar Veeramally wrote:
>> ---
>> android/hal-hidhost.c | 18 ++++++++++++++----
>> 1 file changed, 14 insertions(+), 4 deletions(-)
> This doesn't compile:
>
> CC android/android_libhal_internal_la-hal-hidhost.lo
> android/hal-hidhost.c: In function 'send_data':
> android/hal-hidhost.c:356:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
> free(cmd);
> ^
> android/hal-hidhost.c:356:2: error: incompatible implicit declaration of built-in function 'free' [-Werror]
> cc1: all warnings being treated as errors
> make[1]: *** [android/android_libhal_internal_la-hal-hidhost.lo] Error 1
>
Ok, I will send _v3 of this and rest.
Thanks,
Ravi.
next prev parent reply other threads:[~2013-11-08 9:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 22:10 [PATCH_v2 00/11] Fix issues and implement virtual unplug and send data Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 01/11] android/hid: Remove fixed number of hid set report data length in ipc doc Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 02/11] android/hid: Add a ascii2hex utility Ravi kumar Veeramally
2013-11-08 6:44 ` Jerzy Kasenberg
2013-11-08 8:10 ` Johan Hedberg
[not found] ` <527CA596.6070602@linux.intel.com>
2013-11-08 8:48 ` Johan Hedberg
2013-11-08 9:05 ` Ravi Kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 03/11] android/hid: Fix set report data format Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 04/11] android/hid: Add missing hid send data parameters in ipc document Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 05/11] android/hid: Add missing parameters in send data struct in HAL headers Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 06/11] android/hid: Fill send data structure variables in hal-hidhost Ravi kumar Veeramally
2013-11-08 9:17 ` Johan Hedberg
2013-11-08 9:30 ` Ravi Kumar Veeramally [this message]
2013-11-07 22:10 ` [PATCH_v2 07/11] android/hid: Rename virtual unplug define and struct Ravi kumar Veeramally
2013-11-08 9:18 ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 08/11] android/hid: Add hid event virtual unplug structure to HAL msg headers Ravi kumar Veeramally
2013-11-07 22:10 ` [PATCH_v2 09/11] android/hid: Handle virtual unplug notification in hid hal Ravi kumar Veeramally
2013-11-08 8:39 ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 10/11] android/hid: Add virtual unplug implemention in daemon Ravi kumar Veeramally
2013-11-08 8:37 ` Johan Hedberg
2013-11-07 22:10 ` [PATCH_v2 11/11] android/hid: Add send data " Ravi kumar Veeramally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CAF36.3050709@linux.intel.com \
--to=ravikumar.veeramally@linux.intel.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).