linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Praznik <frank.praznik@oh.rr.com>
To: Szymon Janc <szymon.janc@gmail.com>,
	David Herrmann <dh.herrmann@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Simon Wood <simon@mungewell.org>,
	Frank Praznik <frank.praznik@oh.rr.com>
Subject: Re: [PATCH 3/3] input: Add DualShock 4 detection
Date: Sun, 19 Jan 2014 23:37:11 -0500	[thread overview]
Message-ID: <52DCA7F7.7050704@oh.rr.com> (raw)
In-Reply-To: <1572567.ZoR782tNKQ@athlon>

On 1/18/2014 10:13, Szymon Janc wrote:
> Hi,
>
> On Saturday 18 January 2014 16:05:26 David Herrmann wrote:
>> Hi
>>
>> @Simon and Frank:
>> This patch might help fix your DS4 issues.
>>
>> Cheers
>> David
> Just for clarification, this does not add DS4 support, just detection for it
> in input server. There is some problem with getting SDP records from DS4 by
> bluetoothd (works with sdptool) which prevents idev from being created.
>
> I'm working on fixing this, but no ETA yet.
>
With this and the IMTU patch I was able to get my controller paired.  I 
played around with it and from watching the traffic in btmon, there are 
still two issues that are stopping full two way communications:

1. The Dualshock 4 sends communications to the host on PSM 19, but will 
only receive packets on PSM 17.  Currently the bluetooth stack is trying 
to send data to the controller on PSM 19 so the data packets still 
aren't reaching the it.

2. The hidp layer always assigns a report type of 0xA2 (HIDP_TRANS_DATA 
| HIDP_DATA_RTYPE_OUTPUT) to every HIDP_OUTPUT_REPORT.  The Dualshock 4 
only accepts reports with type 0x52 (HIDP_TRANS_SEND_REPORT | 
HIDP_DATA_RTYPE_OUTPUT).  I was able to work around this with a kludge 
in net/bluetooth/hidp/core.c to catch the Dualshock 4 packets and use 
the value that the controller wants, but I don't think anyone wants a 
device-specific hack in a core protocol file.  Unfortunately, there 
seems to be no elegant way to work around this.

  reply	other threads:[~2014-01-20  4:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 14:57 [PATCH 1/3] eir: Add support for parsing DeviceID info Szymon Janc
2014-01-18 14:57 ` [PATCH 2/3] adapter: Add support for setting DID info from EIR Szymon Janc
2014-01-18 14:57 ` [PATCH 3/3] input: Add DualShock 4 detection Szymon Janc
2014-01-18 15:05   ` David Herrmann
2014-01-18 15:13     ` Szymon Janc
2014-01-20  4:37       ` Frank Praznik [this message]
2014-01-18 19:09 ` [PATCH 1/3] eir: Add support for parsing DeviceID info Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DCA7F7.7050704@oh.rr.com \
    --to=frank.praznik@oh.rr.com \
    --cc=dh.herrmann@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=simon@mungewell.org \
    --cc=szymon.janc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).