From: Michael Knudsen <m.knudsen@samsung.com>
To: Kirill Tkhai <ktkhai@parallels.com>, linux-bluetooth@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH] bluetooth: Do not free priv until timer handler hasn't actually stopped using it
Date: Fri, 14 Feb 2014 13:01:06 +0100 [thread overview]
Message-ID: <52FE0582.3010702@samsung.com> (raw)
In-Reply-To: <1392377748.5384.28.camel@tkhai>
On 02/14/2014 12:35 PM, Kirill Tkhai wrote:
> Function del_timer() does not guarantee that timer was really deleted.
> If the timer handler is beeing executed at the moment, the function
> just returns. So, it's possible to use already freed memory in the handler:
This is not enough. The timer must be deleted in bcsp_close() before
hu->priv is set to NULL as the timer code dereferences hu->priv.
There is a similar issue in hci_h5.c where the timer must be stopped
before purging h5->unack.
-m.
next prev parent reply other threads:[~2014-02-14 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 11:35 [PATCH] bluetooth: Do not free priv until timer handler hasn't actually stopped using it Kirill Tkhai
2014-02-14 12:01 ` Michael Knudsen [this message]
2014-02-14 12:10 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FE0582.3010702@samsung.com \
--to=m.knudsen@samsung.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=ktkhai@parallels.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox