From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>,
Martin Townsend <martin.townsend@xsilon.com>
Cc: linux-zigbee-devel@lists.sourceforge.net,
linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH bluetooth-next] 6lowpan: Remove ununsed dev parameter from skb_delivery_cb callback.
Date: Fri, 01 Aug 2014 12:00:08 +0200 [thread overview]
Message-ID: <53DB6528.2040704@pengutronix.de> (raw)
In-Reply-To: <20140801094144.GA11159@omega>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On 08/01/2014 11:41 AM, Alexander Aring wrote:
> Hi Martin,
>
> On Fri, Aug 01, 2014 at 10:13:55AM +0100, Martin Townsend wrote:
>> This parameter is never used by any function implementing this callback.
>> ---
>> include/net/6lowpan.h | 2 +-
>> net/6lowpan/iphc.c | 2 +-
>> net/bluetooth/6lowpan.c | 4 ++--
>> net/ieee802154/6lowpan_rtnl.c | 5 ++---
>> 4 files changed, 6 insertions(+), 7 deletions(-)
>>
>
> I don't test it yet, but you need to add a Signed-off-by: ...
>
> You can create this with -s parameter while git format-patch.
Usually the Sob is added during the commit with the -s parameter, i.e:
git commit -s
You can modify your commit and add the Sob with:
git commit --amend -s
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-08-01 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 9:13 [PATCH bluetooth-next] 6lowpan: Remove ununsed dev parameter from skb_delivery_cb callback Martin Townsend
2014-08-01 9:41 ` Alexander Aring
2014-08-01 10:00 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB6528.2040704@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
--cc=martin.townsend@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).